Add a (temporary) gecko pref to configure whether picture caching is enabled.

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P2
normal
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: gw, Assigned: kats)

Tracking

(Blocks 1 bug)

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 months ago
This will allow the gfx team to internally test with it enabled for a few days before enabling in nightly. We'll also be able to compare performance, and have an easy way to disable it if we find any bad regressions.

I will add a field to the RendererOptions struct in WR that this preference should set.
Priority: -- → P2
Assignee: nobody → jmuizelaar
Stealing to get this landed
Assignee: jmuizelaar → kats
Comment on attachment 9028416 [details] [diff] [review]
Sketch of the Gecko side patch

Tested locally, this basically works as written. r=me and will land it on inbound.
Attachment #9028416 - Flags: review+

Comment 5

5 months ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/98c147abf490
Add a pref to enable picture caching in WebRender. r=kats

Comment 6

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/98c147abf490
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65

Comment 7

5 months ago
Is it too soon to file bugs with picture-caching enabled?

Updated

5 months ago
Depends on: 1512781

Updated

5 months ago
Depends on: 1512782

Updated

5 months ago
Depends on: 1512783

Updated

5 months ago
Depends on: 1512784

Updated

5 months ago
Depends on: 1512785
(Reporter)

Comment 8

5 months ago
Yea, it's probably a bit too early to report picture caching bugs ideally - there's at least a couple known major bugs I need to fix up before enabling for wider testing. Let's keep those ones open though, I'll make sure they are fixed as part of the changes this week before enabling. Thanks!
No longer depends on: 1512781
No longer depends on: 1512782
No longer depends on: 1512783
No longer depends on: 1512784
No longer depends on: 1512785
You need to log in before you can comment on or make changes to this bug.