Closed
Bug 1510768
Opened 6 years ago
Closed 5 years ago
Promise interface functions should be in their own public header, not jsapi.h
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: jimb, Assigned: jimb)
Details
Attachments
(1 file, 1 obsolete file)
There are many declarations in js/src/jsapi.h related to the promise implementation, the job queue, and so on. Modifications to mega-headers like jsapi.h incur long build times, and it's unhelpful to have a bunch of functions with a common purpose, like promise handling, intermingled with declarations for other, unrelated features. The promise-related declarations should be moved from js/src/jsapi.h to a new header, js/public/Promise.h. Rather than #including the new header from jsapi.h, compilation units that need those declarations should add the new header.
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → jimb
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
Move js/src/jsapi.h declarations related to promises and job queues into their own public header file, js/public/Promise.h. Change the compilation units that need these declarations to #include the new header.
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9028442 -
Attachment is obsolete: true
Pushed by jblandy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/adcf05cc2025 Move SpiderMonkey promise interface into its own header. r=arai
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/adcf05cc2025
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•