Closed Bug 1510798 Opened 6 years ago Closed 6 years ago

Port changes from bug 1506371 and bug 1506915 to Thunderbird

Categories

(Thunderbird :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 65.0

People

(Reporter: robert.strong.bugs, Assigned: Paenglab)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1506915 changes the check for app.update.auto as it was originally implemented in Bug 1458308.
Attached patch 1510798-app-update.patch (obsolete) — Splinter Review
Port of https://hg.mozilla.org/mozilla-central/rev/4939e4a1cc20

This uncomments // nonsensical line still present in M-C: this.promiseAutoUpdateSetting; again.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9028737 - Flags: review?(jorgk)
Comment on attachment 9028737 [details] [diff] [review]
1510798-app-update.patch

Can you please align the file with M-C https://searchfox.org/mozilla-central/source/browser/base/content/aboutDialog-appUpdater.js as much as possible.
Attachment #9028737 - Flags: review?(jorgk)
Summary: Port changes from Bug 1458308 and Bug 1506915 to Thunderbird → Port changes from bug 1506371 and bug 1506915 to Thunderbird
OK, a aligned with M-C as much as possible even if I had to add "aurora" back in :-(
Attachment #9028783 - Flags: feedback?(richard.marti)
Comment on attachment 9028783 [details] [diff] [review]
1510798-app-update.patch - JK

Couldn't test but it looks reasonable.
Attachment #9028783 - Flags: feedback?(richard.marti) → feedback+
You can test it in a Daily.
Keywords: checkin-needed
Attachment #9028737 - Attachment is obsolete: true
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/785c09b1b20e
Port bug 1506371 and bug 1506915: Align aboutDialog-appUpdater.js with M-C. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
(In reply to Jorg K (GMT+1) from comment #5)
> You can test it in a Daily.

If we get a working one. Update doesn't work since the build signing bug.
Depends on: 1514772
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: