Closed Bug 1510909 Opened 10 months ago Closed 10 months ago

Bypass calling nsContentUtils::IsThirdPartyWindowOrChannel() for BEHAVIOR_REJECT_TRACKER

Categories

(Firefox :: Tracking Protection, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

This check <https://hg.mozilla.org/mozilla-central/file/5972866ac7da/toolkit/components/antitracking/AntiTrackingCommon.cpp#l796> is really for BEHAVIOR_REJECT_FOREIGN and BEHAVIOR_LIMIT_FOREIGN.  Profiles show that it can be expensive, so we should avoid doing it for BEHAVIOR_REJECT_TRACKER.
Blocks: 1510275
Calling this function is just a waste of time since we will check
third-partiness a few statements further down.
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/481a655f835e
Bypass calling nsContentUtils::IsThirdPartyWindowOrChannel() for BEHAVIOR_REJECT_TRACKER r=baku
Backed out changeset for assertion failures on AntiTrackingCommon.cpp

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&group_state=expanded&fromchange=481a655f835e07fa9e533ba27b92d10ed784f11c&tochange=66f69c1eb0c2b81acce633c98960bbce974f018e&searchStr=browser%2Cchrome&selectedJob=214880214

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=214880214&repo=autoland&lineNumber=22613

Backout link: https://hg.mozilla.org/integration/autoland/rev/66f69c1eb0c2b81acce633c98960bbce974f018e

08:32:44     INFO - GECKO(886) | Assertion failure: !nsContentUtils::IsThirdPartyWindowOrChannel(aWindow, nullptr, aURI), at /builds/worker/workspace/build/src/toolkit/components/antitracking/AntiTrackingCommon.cpp:918
08:34:16     INFO - GECKO(886) | #01: nsGlobalWindowOuter::SetNewDocument(nsIDocument*, nsISupports*, bool) [dom/base/nsGlobalWindowOuter.cpp:2024]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #02: nsDocumentViewer::InitInternal(nsIWidget*, nsISupports*, mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const&, bool, bool, bool) [layout/base/nsDocumentViewer.cpp:969]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #03: nsDocumentViewer::Init(nsIWidget*, mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const&) [layout/base/nsDocumentViewer.cpp:715]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #04: nsDocShell::SetupNewViewer(nsIContentViewer*) [docshell/base/nsDocShell.cpp:8450]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #05: nsDocShell::Embed(nsIContentViewer*, char const*, nsISupports*) [docshell/base/nsDocShell.cpp:6340]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #06: nsDocShell::CreateContentViewer(nsTSubstring<char> const&, nsIRequest*, nsIStreamListener**) [docshell/base/nsDocShell.cpp:8260]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #07: nsDSURIContentListener::DoContent(nsTSubstring<char> const&, bool, nsIRequest*, nsIStreamListener**, bool*) [docshell/base/nsDSURIContentListener.cpp:183]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #08: nsDocumentOpenInfo::TryContentListener(nsIURIContentListener*, nsIChannel*) [uriloader/base/nsURILoader.cpp:750]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #09: nsDocumentOpenInfo::DispatchContent(nsIRequest*, nsISupports*) [uriloader/base/nsURILoader.cpp:422]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #10: nsDocumentOpenInfo::OnStartRequest(nsIRequest*, nsISupports*) [uriloader/base/nsURILoader.cpp:299]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #11: mozilla::net::HttpChannelChild::DoOnStartRequest(nsIRequest*, nsISupports*) [netwerk/protocol/http/HttpChannelChild.cpp:660]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #12: mozilla::net::HttpChannelChild::OnStartRequest(nsresult const&, mozilla::net::nsHttpResponseHead const&, bool const&, mozilla::net::nsHttpHeaderArray const&, mozilla::net::ParentLoadInfoForwarderArgs const&, bool const&, bool const&, unsigned long long const&, int const&, unsigned int const&, nsTString<char> const&, nsTString<char> const&, mozilla::net::NetAddr const&, mozilla::net::NetAddr const&, unsigned int const&, nsTString<char> const&, long long const&, bool const&, mozilla::net::ResourceTimingStruct const&) [mfbt/RefPtr.h:296]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #13: mozilla::net::StartRequestEvent::Run() [netwerk/protocol/http/HttpChannelChild.cpp:438]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #14: mozilla::net::ChannelEventQueue::RunOrEnqueue(mozilla::net::ChannelEvent*, bool) [xpcom/threads/RecursiveMutex.h:84]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #15: mozilla::net::HttpChannelChild::RecvOnStartRequest(nsresult const&, mozilla::net::nsHttpResponseHead const&, bool const&, mozilla::net::nsHttpHeaderArray const&, mozilla::net::ParentLoadInfoForwarderArgs const&, bool const&, bool const&, unsigned long long const&, int const&, unsigned int const&, nsTString<char> const&, nsTString<char> const&, mozilla::net::NetAddr const&, mozilla::net::NetAddr const&, short const&, unsigned int const&, nsTString<char> const&, long long const&, bool const&, mozilla::net::ResourceTimingStruct const&) [netwerk/protocol/http/HttpChannelChild.cpp:500]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #16: mozilla::net::PHttpChannelChild::OnMessageReceived(IPC::Message const&) [s3:gecko-generated-sources:6b4b2a040befb2f5a64af4251ac420e3e1b7b109a7df328d3437da1bafe4dc4e4bfbfdb5250065ce1841f842b53379f39db9aae884f270be625ca18ae8750f23/ipc/ipdl/PHttpChannelChild.cpp::743]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #17: mozilla::dom::PContentChild::OnMessageReceived(IPC::Message const&) [s3:gecko-generated-sources:cf5d5f62a4ca02a38224e48b025021c31d5c6d1daaae6ae820af374cfc55b178a7e8509bc34cd2acb222808ea085b92a9e8c13b8dd8bcbe36fdb26d0a64e50a8/ipc/ipdl/PContentChild.cpp::5438]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #18: mozilla::ipc::MessageChannel::DispatchAsyncMessage(IPC::Message const&) [ipc/glue/MessageChannel.h:632]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #19: mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) [ipc/glue/MessageChannel.cpp:2051]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #20: mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&) [ipc/glue/MessageChannel.cpp:0]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #21: mozilla::ipc::MessageChannel::MessageTask::Run() [xpcom/threads/Monitor.h:33]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #22: mozilla::SchedulerGroup::Runnable::Run() [xpcom/threads/SchedulerGroup.cpp:299]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #23: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1144]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #24: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:468]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #25: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:86]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #26: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:583]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #27: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:139]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #28: nsAppShell::Run() [widget/cocoa/nsAppShell.mm:745]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #29: XRE_RunAppShell() [toolkit/xre/nsEmbedFunctions.cpp:915]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #30: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:238]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #31: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:583]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #32: XRE_InitChildProcess(int, char**, XREChildData const*) [toolkit/xre/nsEmbedFunctions.cpp:757]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | #33: main [ipc/contentproc/plugin-container.cpp:49]
08:34:16     INFO - 
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 9 (0x11c8bf000) [pid = 890] [serial = 20] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 8 (0x126004800) [pid = 890] [serial = 18] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | ###!!! [Parent][MessageChannel] Error: (msgtype=0x1E0083,name=PBrowser::Msg_Destroy) Channel error: cannot send/recv
08:34:16     INFO - GECKO(886) | ++DOCSHELL 0x111a0d000 == 12 [pid = 886] [id = {39ddedc4-72ff-8e44-8377-b2853096d4cb}]
08:34:16     INFO - GECKO(886) | ++DOMWINDOW == 36 (0x125aaf400) [pid = 886] [serial = 59] [outer = 0x0]
08:34:16     INFO - GECKO(886) | ++DOMWINDOW == 37 (0x12820d800) [pid = 886] [serial = 60] [outer = 0x125aaf400]
08:34:16     INFO - GECKO(886) | [Parent 886, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/base/nsContentUtils.cpp, line 8165
08:34:16     INFO - GECKO(886) | ++DOMWINDOW == 38 (0x110805400) [pid = 886] [serial = 61] [outer = 0x125aaf400]
08:34:16     INFO - GECKO(886) | [Parent 886, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/base/nsContentUtils.cpp, line 8165
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 37 (0x12ced3c00) [pid = 886] [serial = 39] [outer = 0x0] [url = about:preferences#privacy-trackingprotection]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 36 (0x111a39800) [pid = 886] [serial = 45] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 35 (0x12ced1000) [pid = 886] [serial = 38] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 34 (0x128a62c00) [pid = 886] [serial = 42] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 33 (0x12c9b8800) [pid = 886] [serial = 43] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 3 (0x119ede800) [pid = 893] [serial = 20] [outer = 0x0] [url = about:privatebrowsing]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 2 (0x10acf8400) [pid = 893] [serial = 17] [outer = 0x0] [url = about:privatebrowsing]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 1 (0x11b70c400) [pid = 893] [serial = 19] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 0 (0x111fa9000) [pid = 893] [serial = 16] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOCSHELL 0x1257a0800 == 11 [pid = 886] [id = {6533dba4-3e88-d642-ad0a-7fe058b09730}]
08:34:16     INFO - GECKO(886) | --DOCSHELL 0x124a20000 == 10 [pid = 886] [id = {08807d8f-e36a-ba4e-b3b4-1549e76d6a02}]
08:34:16     INFO - GECKO(886) | --DOCSHELL 0x12829f800 == 9 [pid = 886] [id = {cc817f50-bd25-a740-a864-271ccbd8c0f7}]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 32 (0x143e10000) [pid = 886] [serial = 53] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 31 (0x137391400) [pid = 886] [serial = 57] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 30 (0x1170d7000) [pid = 886] [serial = 25] [outer = 0x0] [url = chrome://browser/content/browser.xul]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 29 (0x12ced1400) [pid = 886] [serial = 48] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 28 (0x110804c00) [pid = 886] [serial = 47] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 27 (0x123e31800) [pid = 886] [serial = 51] [outer = 0x0] [url = chrome://browser/content/browser.xul]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 26 (0x137399c00) [pid = 886] [serial = 55] [outer = 0x0] [url = chrome://browser/content/browser.xul]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 25 (0x111a36c00) [pid = 886] [serial = 44] [outer = 0x0] [url = about:preferences#privacy-trackingprotection]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 16 (0x11c854400) [pid = 892] [serial = 34] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 15 (0x1118ca400) [pid = 892] [serial = 25] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 14 (0x11a184400) [pid = 892] [serial = 32] [outer = 0x0] [url = http://trackertest.org/]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 13 (0x11a17c000) [pid = 892] [serial = 29] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 12 (0x1197d0800) [pid = 892] [serial = 26] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 11 (0x11a17dc00) [pid = 892] [serial = 27] [outer = 0x0] [url = http://tracking.example.org/browser/browser/base/content/test/trackingUI/trackingPage.html]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 7 (0x1156db800) [pid = 890] [serial = 19] [outer = 0x0] [url = about:privatebrowsing]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 6 (0x11c8c0000) [pid = 890] [serial = 22] [outer = 0x0] [url = about:privatebrowsing]
08:34:16     INFO - GECKO(886) | --DOCSHELL 0x115622800 == 2 [pid = 890] [id = {70c05a17-9c9b-5948-8470-a8c2438bb692}]
08:34:16     INFO - GECKO(886) | --DOCSHELL 0x12520c000 == 1 [pid = 890] [id = {255fc590-bf26-4a4b-978e-3da257d40a8d}]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 24 (0x12820d800) [pid = 886] [serial = 60] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 23 (0x128219800) [pid = 886] [serial = 58] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 22 (0x12cfec800) [pid = 886] [serial = 49] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 21 (0x12c9c7000) [pid = 886] [serial = 50] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 20 (0x1170dc000) [pid = 886] [serial = 26] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 19 (0x13739b800) [pid = 886] [serial = 56] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 18 (0x12820f000) [pid = 886] [serial = 52] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 17 (0x111a3f800) [pid = 886] [serial = 46] [outer = 0x0] [url = about:preferences#privacy-trackingprotection]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 16 (0x12c9be000) [pid = 886] [serial = 54] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOCSHELL 0x124495800 == 8 [pid = 886] [id = {54edd733-abe4-5640-8982-434e91af4d41}]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 10 (0x10a5e7800) [pid = 892] [serial = 24] [outer = 0x0] [url = http://tracking.example.org/browser/browser/base/content/test/trackingUI/trackingPage.html]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 9 (0x11a183800) [pid = 892] [serial = 41] [outer = 0x0] [url = http://not-tracking.example.com/]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 8 (0x11a187400) [pid = 892] [serial = 33] [outer = 0x0] [url = http://tracking.example.org/browser/browser/base/content/test/trackingUI/trackingPage.html]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 7 (0x11c856800) [pid = 892] [serial = 36] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 6 (0x1118c9400) [pid = 892] [serial = 38] [outer = 0x0] [url = http://tracking.example.org/browser/browser/base/content/test/trackingUI/benignPage.html]
08:34:16     INFO - GECKO(886) | --DOCSHELL 0x11a115800 == 2 [pid = 892] [id = {12f29f66-9b51-4e47-ade6-022d37ef4886}]
08:34:16     INFO - GECKO(886) | --DOCSHELL 0x11a11a000 == 1 [pid = 892] [id = {3bd51013-5164-fd4d-9c58-5bcd63414012}]
08:34:16     INFO - GECKO(886) | --DOCSHELL 0x11a1a1000 == 0 [pid = 892] [id = {c3d478a5-861b-1943-bcad-bd11d9a8c9e2}]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 5 (0x12bb1d000) [pid = 890] [serial = 26] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 4 (0x11c8bf800) [pid = 890] [serial = 21] [outer = 0x0] [url = about:privatebrowsing]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 3 (0x1248d2800) [pid = 890] [serial = 24] [outer = 0x0] [url = about:privatebrowsing]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 2 (0x1248da800) [pid = 890] [serial = 23] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 5 (0x11a185800) [pid = 892] [serial = 42] [outer = 0x0] [url = http://not-tracking.example.com/]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 4 (0x1197d8800) [pid = 892] [serial = 30] [outer = 0x0] [url = http://tracking.example.org/browser/browser/base/content/test/trackingUI/trackingPage.html]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 3 (0x11a180000) [pid = 892] [serial = 35] [outer = 0x0] [url = http://tracking.example.org/browser/browser/base/content/test/trackingUI/trackingPage.html]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 2 (0x11a17c800) [pid = 892] [serial = 37] [outer = 0x0] [url = about:blank]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 1 (0x1197d6c00) [pid = 892] [serial = 40] [outer = 0x0] [url = http://tracking.example.org/browser/browser/base/content/test/trackingUI/benignPage.html]
08:34:16     INFO - GECKO(886) | --DOMWINDOW == 0 (0x11a17cc00) [pid = 892] [serial = 39] [outer = 0x0] [url = about:blank]
08:34:16     INFO - TEST-INFO | started process screencapture
08:34:16     INFO - TEST-INFO | screencapture: exit 0
08:34:16     INFO - Buffered messages logged at 08:32:38
08:34:16     INFO - Entering test bound setup
08:34:16     INFO - Buffered messages logged at 08:32:39
08:34:16     INFO - Leaving test bound setup
08:34:16     INFO - Entering test bound testReportBreakageVisibility
08:34:16     INFO - Console message: [JavaScript Warning: "The resource at “http://trackertest.org/” was blocked because content blocking is enabled." {file: "http://tracking.example.org/browser/browser/base/content/test/trackingUI/trackingPage.html" line: 0}]
08:34:16     INFO - Buffered messages logged at 08:32:40
08:34:16     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_report_breakage.js | report breakage button has the correct visibility - 
08:34:16     INFO - Console message: [JavaScript Warning: "The resource at “http://trackertest.org/” was blocked because content blocking is enabled." {file: "http://tracking.example.org/browser/browser/base/content/test/trackingUI/trackingPage.html" line: 0}]
08:34:16     INFO - Buffered messages logged at 08:32:41
08:34:16     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_report_breakage.js | report breakage button has the correct visibility - 
08:34:16     INFO - Buffered messages logged at 08:32:42
08:34:16     INFO - Console message: [JavaScript Warning: "The resource at “http://trackertest.org/” was blocked because content blocking is enabled." {file: "http://tracking.example.org/browser/browser/base/content/test/trackingUI/trackingPage.html" line: 0}]
08:34:16     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_report_breakage.js | report breakage button has the correct visibility - 
08:34:16     INFO - Buffered messages logged at 08:32:43
08:34:16     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_report_breakage.js | report breakage button has the correct visibility - 
08:34:16     INFO - Buffered messages logged at 08:32:44
08:34:16     INFO - Console message: [JavaScript Warning: "Request to access cookie or storage on “http://trackertest.org/browser/browser/base/content/test/trackingUI/cookieServer.sjs” was blocked because it came from a tracker and content blocking is enabled." {file: "http://not-tracking.example.com/browser/browser/base/content/test/trackingUI/cookiePage.html" line: 0}]
08:34:16     INFO - Console message: [JavaScript Error: "remote browser crashed while on http://not-tracking.example.com/browser/browser/base/content/test/trackingUI/cookiePage.html
08:34:16     INFO - " {file: "chrome://mochikit/content/mochitest-e10s-utils.js" line: 8}]
08:34:16     INFO - e10s_init/<@chrome://mochikit/content/mochitest-e10s-utils.js:8:5
08:34:16     INFO - EventListener.handleEvent*e10s_init@chrome://mochikit/content/mochitest-e10s-utils.js:6:3
08:34:16     INFO - testInit@chrome://mochikit/content/browser-test.js:102:5
08:34:16     INFO - setTimeout handler*@chrome://mochikit/content/browser-test.js:22:1
08:34:16     INFO - loadChromeScripts@jar:file:///var/folders/p4/1g5_kl8n7rv70d6hww9b0t0c00000x/T/tmpYWxnRz.mozrunner/extensions/mochikit@mozilla.org.xpi!/api.js:15:3
08:34:16     INFO - loadMochitest@jar:file:///var/folders/p4/1g5_kl8n7rv70d6hww9b0t0c00000x/T/tmpYWxnRz.mozrunner/extensions/mochikit@mozilla.org.xpi!/api.js:107:3
08:34:16     INFO - @tests/mochitest/runtests.py:1734:1
08:34:16     INFO - @tests/mochitest/runtests.py:1716:2
08:34:16     INFO - evaluate.sandbox/promise<@chrome://marionette/content/evaluate.js:128:13
08:34:16     INFO - evaluate.sandbox@chrome://marionette/content/evaluate.js:97:17
08:34:16     INFO - GeckoDriver.prototype.execute_@chrome://marionette/content/driver.js:1028:19
08:34:16     INFO - async*GeckoDriver.prototype.executeScript@chrome://marionette/content/driver.js:898:24
08:34:16     INFO - Async*despatch@chrome://marionette/content/server.js:291:20
08:34:16     INFO - async*execute@chrome://marionette/content/server.js:264:11
08:34:16     INFO - async*onPacket/<@chrome://marionette/content/server.js:237:15
08:34:16     INFO - async*onPacket@chrome://marionette/content/server.js:236:8
08:34:16     INFO - _onJSONObjectReady/<@chrome://marionette/content/transport.js:490:9
08:34:16     INFO - 
08:34:16     INFO - Buffered messages finished
08:34:16     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/trackingUI/browser_trackingUI_report_breakage.js | Test timed out - 
08:34:16     INFO - GECKO(886) | MEMORY STAT | vsize 4421MB | residentFast 414MB | heapAllocated 90MB
08:34:16     INFO - TEST-OK | browser/base/content/test/trackingUI/browser_trackingUI_report_breakage.js | took 90102ms
08:34:16     INFO - Not taking screenshot here: see the one that was previously logged
Flags: needinfo?(ehsan)
I had a mistake in my assertion.  But more than that, here we may have cases where aURI would be a data: URI, in which case IsThirdPartyWindowOrChannel() would fail and return false, so the assertion needs to take that into account to:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=acdb07696bf275d8d6b04efa5da8ed88dc5810c8
Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e09be458b46
Bypass calling nsContentUtils::IsThirdPartyWindowOrChannel() for BEHAVIOR_REJECT_TRACKER r=baku
https://hg.mozilla.org/mozilla-central/rev/0e09be458b46
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.