Remove the content blocking log and old state from onSecurityChange notifications

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P2
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
Firefox 65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

(Whiteboard: [privacy65])

Assignee

Description

7 months ago
We didn't end up using these, and profiles show that computing them can be expensive.  (Well, the content blocking log to be precise.)

I think we should just revert bug 1493563 part 4 and 11.
Assignee

Updated

7 months ago
Blocks: 1510275
Assignee

Comment 1

7 months ago
(That is backing out parts 4, 5 and 11)

On a local tree, with those changes only I see about 30-40% improvement in the test case in bug 1510275.
We should do this before 65 merges, IMO.
Priority: -- → P2
Whiteboard: [privacy65]
Assignee

Comment 3

7 months ago
I have a try push, may need some more test fixes before it can be reviewed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=82fb40651bf0395161ea05edd9b92e5f415457d0
Assignee

Comment 4

7 months ago
The straightforward backouts can land I think, no need for reviews here...
Blocks: 1493563

Comment 5

7 months ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c259bf672187
Part 1: Backout changeset cdb8932d1d8d (bug 1493563 - Part 11) for regressing performance
https://hg.mozilla.org/integration/mozilla-inbound/rev/82236b4be4c9
Part 2: Backout changeset f8849239da42 (bug 1493563 - Part 5) for regressing performance
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f08283a2e3a
Part 3: Backout changeset d0997972e4d4 (bug 1493563 - Part 4) for regressing performance

Comment 6

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c259bf672187
https://hg.mozilla.org/mozilla-central/rev/82236b4be4c9
https://hg.mozilla.org/mozilla-central/rev/4f08283a2e3a
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.