Closed Bug 1510911 Opened 4 years ago Closed 4 years ago

Remove the content blocking log and old state from onSecurityChange notifications

Categories

(Firefox :: Protections UI, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

(Whiteboard: [privacy65])

We didn't end up using these, and profiles show that computing them can be expensive.  (Well, the content blocking log to be precise.)

I think we should just revert bug 1493563 part 4 and 11.
Blocks: 1510275
(That is backing out parts 4, 5 and 11)

On a local tree, with those changes only I see about 30-40% improvement in the test case in bug 1510275.
We should do this before 65 merges, IMO.
Priority: -- → P2
Whiteboard: [privacy65]
I have a try push, may need some more test fixes before it can be reviewed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=82fb40651bf0395161ea05edd9b92e5f415457d0
The straightforward backouts can land I think, no need for reviews here...
Blocks: 1493563
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c259bf672187
Part 1: Backout changeset cdb8932d1d8d (bug 1493563 - Part 11) for regressing performance
https://hg.mozilla.org/integration/mozilla-inbound/rev/82236b4be4c9
Part 2: Backout changeset f8849239da42 (bug 1493563 - Part 5) for regressing performance
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f08283a2e3a
Part 3: Backout changeset d0997972e4d4 (bug 1493563 - Part 4) for regressing performance
https://hg.mozilla.org/mozilla-central/rev/c259bf672187
https://hg.mozilla.org/mozilla-central/rev/82236b4be4c9
https://hg.mozilla.org/mozilla-central/rev/4f08283a2e3a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.