Closed Bug 1510919 Opened 5 years ago Closed 5 years ago

Make mach clang-format support .cc files

Categories

(Developer Infrastructure :: Lint and Formatting, defect)

defect
Not set
normal

Tracking

(firefox-esr60 fixed, firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox-esr60 --- fixed
firefox65 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(2 files)

      No description provided.
Blocks: 1423111
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19475486e596
Make mach clang-format support .cc files r=andi
https://hg.mozilla.org/mozilla-central/rev/19475486e596
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Attached patch ESR patchSplinter Review
[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): NPOTB

String or UUID changes made by this patch: None
Attachment #9030741 - Flags: approval-mozilla-esr60?
Attachment #9030741 - Attachment is patch: true
Attachment #9030741 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 9030741 [details] [diff] [review]
ESR patch

OK for uplift to ESR60 as part of the clang-format project.
Attachment #9030741 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Target Milestone: Firefox 65 → mozilla65
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: