Closed
Bug 1510919
Opened 5 years ago
Closed 5 years ago
Make mach clang-format support .cc files
Categories
(Developer Infrastructure :: Lint and Formatting, defect)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox-esr60 fixed, firefox65 fixed)
RESOLVED
FIXED
mozilla65
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(2 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
959 bytes,
patch
|
lizzard
:
approval-mozilla-esr60+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/19475486e596 Make mach clang-format support .cc files r=andi
Comment 3•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/19475486e596
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Assignee | ||
Comment 4•5 years ago
|
||
[ESR Uplift Approval Request] If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format. User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future. Fix Landed on Version: 65 Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): NPOTB String or UUID changes made by this patch: None
Attachment #9030741 -
Flags: approval-mozilla-esr60?
Assignee | ||
Updated•5 years ago
|
Attachment #9030741 -
Attachment is patch: true
Attachment #9030741 -
Attachment mime type: application/octet-stream → text/plain
Updated•5 years ago
|
status-firefox-esr60:
--- → affected
Comment 5•5 years ago
|
||
Comment on attachment 9030741 [details] [diff] [review] ESR patch OK for uplift to ESR60 as part of the clang-format project.
Attachment #9030741 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Assignee | ||
Comment 6•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr60/rev/e2351e9f68c5
Updated•5 years ago
|
Target Milestone: Firefox 65 → mozilla65
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•