1510941 - [wpt-sync] Sync PR 14291 - [WebCryptoAPI] Remove race condition

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 14291 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14291
Details from upstream follow.

Mike Pennisi <[e-mail]> wrote:
>  [WebCryptoAPI] Remove race condition
>  
>  Configure testharness.js to wait until the global `done` function is
>  invoked before reporting results. This ensures that all
>  asynchronously-declared tests are defined and subsequently executed
>  regardless of variations in timing.
>  
>  ---
>  
>  The instability is apparent when comparing the test results between Chrome, Firefox, and Safari, e.g. https://wpt.fyi/results/WebCryptoAPI/sign_verify?sha=58523789a0
>  
>  ![2018-11-28-crypto-race](https://user-images.githubusercontent.com/677252/49188529-17a25480-f339-11e8-89bc-e4608ca7b954.png)
>  
>  Firefox and Safari are missing results from tests that depend on `WebCryptoAPI/sign_verify/ecdsa.js` due to the race condition which this patch corrects.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=15222bd25f9c22fc83f3314f674ce4720690637f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=45dba65a8241df40c35b50f4aabb1e93795842df

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 8 tests and 512 subtests
OK     : 7
PASS   : 344
FAIL   : 168

Tests that are disabled for instability:
/WebCryptoAPI/sign_verify/test_ecdsa.https.html

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80137a026cf2
[wpt PR 14291] - [WebCryptoAPI] Remove race condition, a=testonly

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/80137a026cf2