Closed Bug 1510941 Opened 6 years ago Closed 5 years ago

[wpt-sync] Sync PR 14291 - [WebCryptoAPI] Remove race condition

Categories

(Core :: DOM: Security, enhancement, P4)

Product:
Core
Component:
DOM: Security
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream][domsecurity-backlog]) 

Sync web-platform-tests PR 14291 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14291
Details from upstream follow.

Mike Pennisi <mike@mikepennisi.com> wrote:
>  [WebCryptoAPI] Remove race condition
>  
>  Configure testharness.js to wait until the global `done` function is
>  invoked before reporting results. This ensures that all
>  asynchronously-declared tests are defined and subsequently executed
>  regardless of variations in timing.
>  
>  ---
>  
>  The instability is apparent when comparing the test results between Chrome, Firefox, and Safari, e.g. https://wpt.fyi/results/WebCryptoAPI/sign_verify?sha=58523789a0
>  
>  ![2018-11-28-crypto-race](https://user-images.githubusercontent.com/677252/49188529-17a25480-f339-11e8-89bc-e4608ca7b954.png)
>  
>  Firefox and Safari are missing results from tests that depend on `WebCryptoAPI/sign_verify/ecdsa.js` due to the race condition which this patch corrects.
Component: web-platform-tests → DOM: Security
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream][domsecurity-backlog]
Ran 8 tests and 512 subtests
OK     : 7
PASS   : 344
FAIL   : 168

Tests that are disabled for instability:
/WebCryptoAPI/sign_verify/test_ecdsa.https.html
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80137a026cf2
[wpt PR 14291] - [WebCryptoAPI] Remove race condition, a=testonly
https://hg.mozilla.org/mozilla-central/rev/80137a026cf2
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.