Closed Bug 1510952 Opened 10 months ago Closed 10 months ago
TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/quick-filter-bar/test-display-issues
.js | test-display-issues .js::test _buttons _collapse _and _expand
TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/quick-filter-bar/test-display-issues.js | test-display-issues.js::test_buttons_collapse_and_expand This appears to be Linux only. I'll post the regression range in a minute. https://taskcluster-artifacts.net/Au7Y-d-gS-KgVOHltzSBGg/0/public/logs/live_backing.log EXCEPTION: Timeout waiting for resize (is the screen resolution at least 1280 x 1024?)
Whiteboard: [Thunderbird-testfailure: Z Linux only] → [Thunderbird-testfailure: Z Linux only][Thunderbird-disabled-test]
Aceman, maybe something for you.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/comm-central/rev/38702511b5ce Disable failing part of test-display-issues.js on Linux. rs=bustage-fix
Test failure first see on Wed, Nov 28, 2018, 23:36:30 here: https://treeherder.mozilla.org/#/jobs?repo=comm-central&selectedJob=214495044&revision=bfe80ab94c1223fecddc29073fbd1b076c10e4b1 M-C last good: 4a3f88e3629875813584f135f9e250b82e M-C first bad: f2915d3ee5f8705676e4bb643eab54b622 https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4a3f88e3629875813584f135f9e250b82e&tochange=f2915d3ee5f8705676e4bb643eab54b622 I can't see anything in that range.
In the test we call window.resizeTo(600, 768) but the window resizes to 608x768 (window.outerWidth == 608) and we abort on that as the size does not match. I also don't see which change in the range would cause this.
As I read it the last good is a12d80e08655c13245add6f6dacc91f8a6, but I still see nothing interesting there. https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a12d80e08655c13245add6f6dacc91f8a6&tochange=f2915d3ee5f8705676e4bb643eab54b622
Got that wrong: M-C last good: a12d80e08655c13245add6f6dacc91f8a6 M-C first bad: 5c66354bff282452a6f1a3c911fa8756b6 https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a12d80e08655c13245add6f6dacc91f8a6&tochange=5c66354bff282452a6f1a3c911fa8756b6 Same range as bug 1510616.
https://hg.mozilla.org/mozilla-central/rev/4b9f8acdf5f7#l4.35 With this overflow no longer hidden, the 600px is not wide enough to display the window contents, so it resizes to 608px instead.
Hiding the Today Pane fixes our problem, as we do in pref-window/test-font-chooser.js.
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9029162 - Flags: review?(jorgk)
Comment on attachment 9029162 [details] [diff] [review] 1510952-qfb-test-1.diff OK, thanks. I would usually give the review to Aceman not to get into trouble, but this trick is prior art, so it should be OK here, too.
Attachment #9029162 - Flags: review?(jorgk) → review+
Pushed by email@example.com: https://hg.mozilla.org/comm-central/rev/a04f9cd37145 Hide Today Pane to fix failing test quick-filter-bar/test-display-issues.js. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.