Closed Bug 1510959 Opened 6 years ago Closed 6 years ago

[RTL] Settings icons on the site identity panel are not aligned when in hover state

Categories

(Firefox :: Site Identity, defect, P2)

Product:
Firefox
Component:
Site Identity
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 65
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- unaffected
firefox65 --- verified

People

(Reporter: itiel_yn8, Assigned: ewright)

References

Details

(Keywords: regression, rtl, Whiteboard: [privacy65])

Attachments

(3 files)

LTR
34.12 KB, image/png
Details
RTL
33.71 KB, image/png
Details
Bug 1510959 - [RTL] Settings icons on the site identity panel are aligned.
47 bytes, text/x-phabricator-request
Details | Review 
This is a regression from bug 1509558.

STR:
1. Change Nightly's UI to RTL (set intl.uidirection to 1 in about:config) and restart Nightly
2. In this page you're on, open the site identity panel
3. Hover both settings icons (of Content Blocking and Permissions).

AR:
The settings icons are not aligned.

ER:
Should be aligned.

See screenshots of both RTL (bad) and LTR (good).
Attached image LTR — 

    
    

    
  

      
      
      
      

        Attached image
          
        RTL
        — 
      

    


  

    
    

    
  
Thank you, I missed it, it needs "8px" to be added to the background-position here:
https://searchfox.org/mozilla-central/source/browser/themes/shared/controlcenter/panel.inc.css#148
Priority: -- → P2
Whiteboard: [privacy65]

    
  
Assignee: nobody → ewright

    
  
Status: NEW → ASSIGNED

    
    

    
  


  
Icons needed to be moved over by 8px in rtl to match ltr.

    
    

    
  
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/65511560940f
[RTL] Settings icons on the site identity panel are aligned. r=Ehsan

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/65511560940f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago

          status-firefox65:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65

    
    

    
  
Looking good on latest Nightly. Thanks!
Status: RESOLVED → VERIFIED

          status-firefox65:
          fixed → verified

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: