1510964 - ALL of my saved passwords containing åäöÅÄÖ are effed up

Status: RESOLVED INCOMPLETE

(Toolkit :: Password Manager, defect)

Description

[mikael.jonsson]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce:

I was about to log on to mega.nz after a reboot and update to 63.0.3. Somehow my saved password was wrong. I was using characters that are not in the a-z range. It looked like when files are sent from Mac/PC/Mac/PC... blabla and the characters are all effed up. Luckily I knew my password and could log in and change it.


Actual results:

I'm not showing the exact results since it would compromise my password generating procedure. The password saved was effed up where the non a-z range characters were.


Expected results:

It should have kept my passwords intact without the weird change, of course.

Comment 1

[mikael.jonsson]

I just checked and ALL passwords containing non a-z characters are effed up now.

Comment 2

[mikael.jonsson]

https://imgur.com/a/YAMn7T3

Comment 3

[Daniel Bodea [:danibodea]]

I could not reproduce this issue in any way. I have set a password containing all of the special characters mentioned for several sites. I have saved these passwords inside the browser and upgraded from Release v63.0.1 to v63.0.3. The passwords were saved correctly in the "Saved passwords" section, the logins were properly made using the autofill feature. 
I can't see any other way to try and reproduce your issue. 

1. Did I try a valid reproduction process? What have you done differently than me?
2. Where exactly did the characters get "effed up"? In the hidden auto-filled password when attempting to log in? In the Saved passwords" section of the browser's options?
3. Are there any other details that you think might be of help?

Thank you for your contribution!

Comment 4

[mikael.jonsson]

(In reply to undefined from comment #undefined)
> 

I'm sorry, I wanted to report a bug, but I didn't find any way to report it easily. It's not that I can reproduce it, nor have I the intention to. I simply wanted to report a bug that happened to me. My passwords are effed up. Both in the saved passwords section and when they are getting auto-filled. And it happened after last update. Sorry if I can't be more helpful.

Comment 5

[Daniel Bodea [:danibodea]]

I cannot confirm this issue as I cannot reproduce it. I will set it's component to (Toolkit) Password Manager and hope that a developer picks it up and has an opinion that can move it forward. Please need info me if more testing is needed.

I have one last question for the reporter:
Mikael, do you have any idea which version you had before the update?

Comment 6

[mikael.jonsson]

(In reply to Bodea Daniel [:danibodea] from comment #5)
> I cannot confirm this issue as I cannot reproduce it. I will set it's
> component to (Toolkit) Password Manager and hope that a developer picks it
> up and has an opinion that can move it forward. Please need info me if more
> testing is needed.
> 
> I have one last question for the reporter:
> Mikael, do you have any idea which version you had before the update?

I'm afraid I can't be sure. It could have been a week or two since last update before the bug occured, whichever version was active then. I'm sorry I can't be of more help.

Comment 7

[Matthew N. [:MattN]]

Bodea, could you try again with version 52 => 63 just to be sure… no upgrade should cause this issue. Please make sure you are testing on Windows 10 too.

Comment 8

[Daniel Bodea [:danibodea]]

I had an unexpected break-through in reproducing this issue:

Firstly, the reproduction of this issue could not be achieved because it was blocked by bug 1289947 (the passwords on some sites could not be saved in Firefox because the "Save Password" pop/up/module would not be displayed). This given, I saved the login in Chrome and imported it into Firefox Release v52.0.2. Once I checked whether the password was saved correctly in Firefox, I noticed that some special characters would be saved/displayed incorrectly, as the reporter mentioned.

I have tried to import the same password in Firefox Release v56.0 or v64.0, Beta v65.0b4 and Nightly v66.0a1 and had the same results. The password is incorrectly saved when importing them from Chrome.

Considering all of the above, this issue is most probably NOT caused by the update, but by importing the credentials.

@Matthew: I think this issue is not related to bug 1508149 because it affects/changes passwords with special characters, does not lose them.
@Mikael: Do you know whether you imported passwords or not?

P.S. I will attach a pic with the password in chrome and Firefox with the hope that it will help fix the importing issue.

Comment 9

[Daniel Bodea [:danibodea]]

Attachment: Password imported from Chrome to Firefox is messed up because of the special characters.png

Password imported from Chrome to Firefox is messed up because of the special characters.png

Comment 10

[Matthew N. [:MattN]]

(In reply to mikael.jonsson from comment #0)

It looked like when files are sent from Mac/PC/Mac/PC...
blabla and the characters are all effed up.

How are you sharing the data between Mac and PC? With Firefox Sync or some other software?

Comment 11

[Matthew N. [:MattN]]

What language is your Firefox interface shown in?

Comment 12

[Matthew N. [:MattN]]

Since I haven't heard back and I'm not sure if the original problem was because of an import/migration, I filed bug 1520949 for that issue.

Comment 13

[Daniel Bodea [:danibodea]]

I think we should use this bug for the case I found relating "messed up" passwords, mentioned in comment 8.
Do you think it would be better to log a separate issue?

Comment 14

[Matthew N. [:MattN]]

(In reply to Bodea Daniel [:danibodea] from comment #13)

I think we should use this bug for the case I found relating "messed up" passwords, mentioned in comment 8.
Do you think it would be better to log a separate issue?

Did you see comment 12? Isn't that covering the comment 8 case?

Comment 15

[Daniel Bodea [:danibodea]]

Right, sorry. Thanks!