1510966 - Code Style Warning: Unneccessary code

Status: RESOLVED FIXED

(GeckoView :: General, task, P5)

Description

[Emily Toop (:fluffyemily)]

Unnecessary enum modifier

Reports on any redundant modifiers on enumerated classes or components of enumerated classes.

Affected Classes:

AndroidGamepadManager
BaseHlsPlayer
DynamicToolbarAnimator
GeckoHLSDemuxerWrapper
GeckoScreenOrientation
GeckoSession
GeckoThread
ThreadUtils

Unneccessary interface modifier

Reports any redundant modifiers on interfaces or interface components.

Affected Classes:

AsyncCodec
BaseHlsPlayer
DynamicToolbarAnimator
EventCallback
GeckoAppShell
GeckoMediaDrm
GeckoProfileDirectories
GeckoSession
NativeReference
SessionTextInput
TelemetryContract
TouchEventInterceptor
WakeLockDelegate

Unnecessary semicolon

Reports on any unnecessary semicolons, whether between class members, inside block statements, or after class definitions. While valid Java, these semicolons are redundant, and may be removed.

Affected Classes:

AllowOrDeny
GeckoAppShell
GeckoHalDefines
GeckoWebExecutor
HttpBin
RemoteManager
WebRequest

Comment 1

[Lukas]

Hi!
I'm new to the community and would like to attempt this for my first bug. If no one is working on this, can I be assigned to give it a shot?

Thanks!

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Hi Lukas, sure, let me know if you need any help with it!

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

There is some good documentation here: https://mozilla.github.io/geckoview/tutorials/geckoview-quick-start.html

Comment 4

[Chris Peterson [:cpeterson]]

Enhancements should have severity N/A.

Comment 5

[Logan Rosen [:Logan]]

Attachment: Bug 1510966 - address 'Unnecessary modifier' warnings r?#geckoview-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52fc1e3d5a2a
address 'Unnecessary modifier' warnings r=geckoview-reviewers,calu

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/52fc1e3d5a2a