1510970 - Java Warning: Redundant conditional expression

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P5)

Description

[Emily Toop (:fluffyemily)]

Reports conditional expressions which can be replaced by simpler but equivalent expressions. 
Example
→
Replacement
condition ? true : false

condition
condition ? false : true

!condition
value == null ? null : value

value
result != 0 ? result : 0

result
a == b ? a : b

b

Affected Classes:

GeckoRuntimeSettings
GeckoSurface

Comment 1

[Nirmay Dhruv [:nirmay]]

Hello, can I contribute to this bug?

Comment 2

[Chris Peterson [:cpeterson]]

This bug is still relevant:

https://searchfox.org/mozilla-central/search?q=%3F+true&path=.java&case=true&regexp=false

mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/GeckoSurface.java
46 mIsSingleBuffer = p.readByte() == 1 ? true : false;
47 mIsAvailable = (p.readByte() == 1 ? true : false);

mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java
657 return mWebFonts.get() != 0 ? true : false;

Comment 3

[Logan Rosen [:Logan]]

Attachment: Bug 1510970 - simplify redundant conditional expressions r?#geckoview-reviewers

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9671bf4fb2b
simplify redundant conditional expressions r=geckoview-reviewers,owlish

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e9671bf4fb2b