1510975 - Java Error: Wrong Package Statement

Status: RESOLVED FIXED

(GeckoView :: General, defect, P5)

Description

[Emily Toop (:fluffyemily)]

Detects package statements that do not correspond to the project directory structure and reports classes without package statements.

Affected Class

SurfaceTextureListener

Package name 'org.mozilla.gecko' does not correspond to the file path 'org.mozilla.gecko.gfx'

Comment 1

[[:samihda]]

Does anybody have more details on which part of the codebase is affected and what we want to do here exactly?

Perhaps some shell script to check if the package names match the directory, something like that?

I'm just trying to see if I can help address this issue.

Comment 2

[Makoto Kato [:m_kato]]

(In reply to [:samihda] from comment #1)

Does anybody have more details on which part of the codebase is affected and what we want to do here exactly?

https://searchfox.org/mozilla-central/rev/275630dfceb88eee07e4c7d38cd021dd39c2ab23/mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/SurfaceTextureListener.java#6 should be org.mozilla.gecko.gfx;

Perhaps some shell script to check if the package names match the directory, something like that?

Unnecessary.

If you want to contribute the fix for this bug, please reference https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html to create a patch and https://firefox-source-docs.mozilla.org/mobile/android/geckoview/contributor/geckoview-quick-start.html to build GeckoView at first.

Comment 3

[[:samihda]]

I see, thanks for the clarification. I will take a look.

Comment 4

[[:samihda]]

Attachment: Bug 1510975 - Match package name with file path. r=m_kato

Comment 5

[[:samihda]]

The build is fine on my end, and I've submitted the patch. I think I don't have access to the Try server though. I'm not sure what the next steps here should be.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d16467822488
Match package name with file path. r=m_kato,geckoview-reviewers

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/d16467822488

Comment 8

[Chris Peterson [:cpeterson]]

Thanks for your contribution, samihda!

If you're looking for more good Android bugs, here are some you might consider:

https://bugzilla.mozilla.org/buglist.cgi?product=GeckoView&priority=P3&priority=P5&query_format=advanced&keywords_type=allwords&keywords=good-first-bug&resolution=---