1511011 - [Wayland] MozContainer cleanup

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

Clean up of MozContainer code.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1511011 - Removed moz_container_move as it's not used, r=jhorak

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1511011 - Clean up wayland subsurface creation/management, r=jhorak

- Don't create wl_subsurface in map event but rather when it's requested by compositor.
- Don't create wl_surface at nsWindow::OnExposeEvent but check ready_to_draw instead.
- Rename parent_surface_committed_handler to frame_clock_after_paint_handler.
- Rename parent_surface_committed to ready_to_draw.
- Rename needs_clear to surface_needs_clear.

Depends on D13404

Comment 3

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=409ee34f1ccd8a28d0aea70ac5e967686be10267

Comment 4

[Narcis Beleuzu [:NarcisB]]

Martin, the patches failed to land.

Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpcGU_L3\npatching file widget/gtk/mozcontainer.h\nHunk #1 FAILED at 87\n1 out of 1 hunks FAILED -- saving rejects to file widget/gtk/mozcontainer.h.rej\npatching file widget/gtk/mozcontainer.cpp\nHunk #1 FAILED at 127\n1 out of 1 hunks FAILED -- saving rejects to file widget/gtk/mozcontainer.cpp.rej\nabort: patch failed to apply', ''

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Okay, Thanks.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Patch re-based to latest trunk.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/819a462d5dd0
Removed moz_container_move as it's not used, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/f349e5a7d515
Clean up wayland subsurface creation/management, r=jhorak

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/819a462d5dd0
https://hg.mozilla.org/mozilla-central/rev/f349e5a7d515