[Wayland] MozContainer cleanup

RESOLVED FIXED in Firefox 65

Status

()

enhancement
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: stransky, Assigned: stransky)

Tracking

(Blocks 1 bug)

Trunk
mozilla65
Desktop
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

6 months ago
Clean up of MozContainer code.
Assignee

Updated

6 months ago
OS: FreeBSD → Linux
Assignee

Comment 2

6 months ago
- Don't create wl_subsurface in map event but rather when it's requested by compositor.
- Don't create wl_surface at nsWindow::OnExposeEvent but check ready_to_draw instead.
- Rename parent_surface_committed_handler to frame_clock_after_paint_handler.
- Rename parent_surface_committed to ready_to_draw.
- Rename needs_clear to surface_needs_clear.

Depends on D13404
Assignee

Updated

6 months ago
Keywords: checkin-needed
Martin, the patches failed to land.

Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpcGU_L3\npatching file widget/gtk/mozcontainer.h\nHunk #1 FAILED at 87\n1 out of 1 hunks FAILED -- saving rejects to file widget/gtk/mozcontainer.h.rej\npatching file widget/gtk/mozcontainer.cpp\nHunk #1 FAILED at 127\n1 out of 1 hunks FAILED -- saving rejects to file widget/gtk/mozcontainer.cpp.rej\nabort: patch failed to apply', ''
Flags: needinfo?(stransky)
Assignee

Comment 5

6 months ago
Okay, Thanks.
Flags: needinfo?(stransky)
Assignee

Comment 6

6 months ago
Patch re-based to latest trunk.
Keywords: checkin-needed

Comment 7

6 months ago
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/819a462d5dd0
Removed moz_container_move as it's not used, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/f349e5a7d515
Clean up wayland subsurface creation/management, r=jhorak
Keywords: checkin-needed

Comment 8

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/819a462d5dd0
https://hg.mozilla.org/mozilla-central/rev/f349e5a7d515
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Assignee

Updated

6 months ago
Blocks: 1511973
You need to log in before you can comment on or make changes to this bug.