localize "This Firefox" runtime name

VERIFIED FIXED in Firefox 66

Status

enhancement
P1
normal
VERIFIED FIXED
6 months ago
2 months ago

People

(Reporter: ogasidlo, Assigned: jdescottes)

Tracking

(Blocks 2 bugs)

unspecified
Firefox 66
Dependency tree / graph

Firefox Tracking Flags

(firefox66 verified, firefox67 verified, firefox68 verified)

Details

Attachments

(1 attachment)

Reporter

Description

6 months ago
"This Firefox" localized in the sidebar,but it seems we are hard coding it as a `runtime` name (what gets displayed as part of the heading in the runtime page).

So we want to localize it here too.
Reporter

Updated

6 months ago
Assignee: nobody → ogasidlo
Status: NEW → ASSIGNED
Reporter

Updated

6 months ago
Priority: -- → P1
Summary: localize "This Firefox" runtime name → [meta] localize "This Firefox" runtime name
Assignee

Updated

4 months ago
Assignee: ogasidlo → jdescottes
Assignee

Comment 1

4 months ago

At the moment the hardcoded "This Firefox" name in the runtimes state is not displayed anywhere. The runtime header for This Firefox only shows the name of app and its version (eg "Firefox Nightly 66 (66.0a1)").

In theory, we could do nothing since the string is not displayed, or make the name string optional in the runtime type and skip it for This Firefox. But I think for consistency it would be better to keep the string and localize it properly. The only issue with this is that the This Firefox runtime is created in the default state right at the beginning, before the localization module has been initialized.

We can either workaround this issue by loading the create-store.js module using a lazyRequire (in practice we need to make sure we don't try to create the state before the l10n module is available). Or we just remove This Firefox from the default state and we let aboutdebugging.js populate the state with This Firefox.

Assignee

Comment 2

4 months ago
This approach forces to have a new action here, but the alternative was to create
the store after initializing l10n.js, which breaks all the tests because our current helper
waitForRequestsSuccess is quite fragile.
Keywords: meta
Summary: [meta] localize "This Firefox" runtime name → localize "This Firefox" runtime name
Assignee

Updated

4 months ago
Blocks: 1520525

Comment 3

4 months ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0eafc7a46433
Localize runtime name This Firefox in aboutdebugging state;r=Ola,ladybenko

Comment 4

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

Comment 5

2 months ago

I've verified on Nightly 68.0a1, Firefox Developer Edition 67.0, release 66.0.1 - on all versions the "This Firefox" will appear at the sidebar - top left side.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.