localize "This Firefox" runtime name
Categories
(DevTools :: about:debugging, enhancement, P1)
Tracking
(firefox66 verified, firefox67 verified, firefox68 verified)
People
(Reporter: ogasidlo, Assigned: jdescottes)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
Reporter | ||
Updated•7 years ago
|
Reporter | ||
Updated•7 years ago
|
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 1•7 years ago
|
||
At the moment the hardcoded "This Firefox" name in the runtimes state is not displayed anywhere. The runtime header for This Firefox only shows the name of app and its version (eg "Firefox Nightly 66 (66.0a1)").
In theory, we could do nothing since the string is not displayed, or make the name
string optional in the runtime type and skip it for This Firefox. But I think for consistency it would be better to keep the string and localize it properly. The only issue with this is that the This Firefox runtime is created in the default state right at the beginning, before the localization module has been initialized.
We can either workaround this issue by loading the create-store.js module using a lazyRequire (in practice we need to make sure we don't try to create the state before the l10n module is available). Or we just remove This Firefox from the default state and we let aboutdebugging.js populate the state with This Firefox.
Assignee | ||
Comment 2•7 years ago
|
||
Updated•7 years ago
|
Comment 4•6 years ago
|
||
bugherder |
Comment 5•6 years ago
|
||
I've verified on Nightly 68.0a1, Firefox Developer Edition 67.0, release 66.0.1 - on all versions the "This Firefox" will appear at the sidebar - top left side.
Description
•