Closed Bug 1511043 Opened 6 years ago Closed 6 years ago

Synchronize the replay timeline and console

Categories

(Core Graveyard :: Web Replay, defect)

defect
Not set
normal

Tracking

(firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file)

The replay timeline should be in sync with the console:

- hovering on a message in the console highlights the marker in the timeline
- filtering messages in the console filters messages in the timeline
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/891b3a495ff5
Synchronize the replay timeline and console. r=nchevobbe
Backed out changeset 891b3a495ff5 (bug 1511043) for devtools failures at browser/base/content/test/static/browser_all_files_referenced.js

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/770d5f3d96f226d68137fe837c97e6d13239fe98

Failure push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=891b3a495ff55685a1b772d013d803a3d4c6879e

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=214903639&repo=mozilla-inbound&lineNumber=1599

17:44:41     INFO - unreferenced devtools resource file: resource://devtools/shared/jsbeautify/src/beautify-js.js
17:44:41     INFO - unreferenced devtools resource file: resource://devtools/shared/jsbeautify/src/beautify-tests.js
17:44:41     INFO - unreferenced devtools resource file: resource://devtools/shared/platform/cache-entry.js
17:44:41     INFO - unreferenced devtools resource file: resource://devtools/shared/platform/clipboard.js
17:44:41     INFO - unreferenced devtools resource file: resource://devtools/shared/platform/stack.js
17:44:41     INFO - unreferenced devtools resource file: resource://devtools/shared/specs/timeline.js
17:44:41     INFO - Buffered messages finished
17:44:41     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 1, expected 0
17:44:41     INFO - Stack trace:
17:44:41     INFO - chrome://mochikit/content/browser-test.js:test_is:1303
17:44:41     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:774
17:44:41     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093
17:44:41     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084
17:44:41     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:982
17:44:41     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
17:44:41     INFO - Not taking screenshot here: see the one that was previously logged
17:44:41     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://devtools/skin/images/webconsole/jump.svg - 
17:44:41     INFO - Stack trace:
17:44:41     INFO - chrome://mochikit/content/browser-test.js:test_ok:1292
17:44:41     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:778
17:44:41     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093
17:44:41     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084
17:44:41     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:982
17:44:41     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
17:44:41     INFO - ignored unused whitelist entry: resource://app/blocklist.xml
17:44:41     INFO - ignored unused whitelist entry: resource://gre/gmp-clearkey/0.1/manifest.json
17:44:41     INFO - ignored unused whitelist entry: resource://gre/res/test.properties
Flags: needinfo?(jlaster)
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3124848b93c4
Revert "Backed out changeset 891b3a495ff5 for devtools failures at browser/base/content/test/static/browser_all_files_referenced.js"
sorry about that. I often forget to run the browser lint tests in try... 

I removed the jump.svg file and we should be good now.
Flags: needinfo?(jlaster)
ugh, i'm sorry :cbrindusan, i'm rushing a bit before all hands. I'll slow down and make sure try is green here.
Flags: needinfo?(jlaster)
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a80928fff29
Revert "Backed out changeset 3124848b93c4 for build bustages on jump.svg. CLOSED TREE"
https://hg.mozilla.org/mozilla-central/rev/891b3a495ff5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Assignee: nobody → jlaster
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: