1511075 - cannot reach "Clear Downloads" button in Library > Download with keyboard

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P5)

Description

[Michal Stanke (Mozilla.cz) [:MikkCZ][:mstanke] (use needinfo)]

Attachment: screenshot

From one of sightless users of Firefox, we've got a feedback that the button "Clear Downloads" in Firefox Library is not accessible - does not have any accesskey assigned. It's the button in the top right corner on the attached screenshot.

How to find:
1) Open Firefox Library window. (e.g. Ctrl+Shift+H)
2) In the left navigation sidebar go to Downloads.
3) Check the top button "Clear Downloads" in the top right corner (toolbarbutton id "clearDownloadsButton", string "clearDownloadsButton.label" in browser/chrome/browser/downloads/downloads.dtd).

Comment 1

[Josef Krasny]

I agree, it is inaccessible if you use keyboard only. Cannot access this button with TAB key and no accesskey is assigned to this button.

Comment 2

[Chaitanya P]

Hi there, I think I have a working fix for this bug.

Can I please be assigned to it?

Comment 3

[Asa Dotzler [:asa]]

Chaitanya, yes, please take this bug if you have a fix.

Comment 4

[Asa Dotzler [:asa]]

It appears this button is not in the tab order at all so completely inaccessible.

Comment 5

[Marco Bonardo [::mak] (Away 7-25 Aug)]

It looks like the tabbable attribute is set only on Mac, likely by mistake because we do that on toolbarbuttons with type="menu", and this is not one of those. I'm not sure whether that'd be enough, but likely worth for someone to try and see.
The code is here:
https://searchfox.org/mozilla-central/rev/b9da45f63cb567244933c77b2c7e827a057d3f9b/browser/components/places/content/places.xul#343

Likely this has always been broken, unsetting version flags.

Comment 7

[Marco Bonardo [::mak] (Away 7-25 Aug)]

We assign the bugs when patches are attached, feel free to start working on it, and ask questions.

Comment 8

[danner.simon]

Attachment: Bug 1511075 - Make Clear Downloads button always tabbable not only on OSX

Comment 9

[Marco Bonardo [::mak] (Away 7-25 Aug)]

Thank you for the patch! I triggered the landing.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ac292cba16c
Make Clear Downloads button always tabbable not only on OSX r=mak

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0ac292cba16c

Comment 12

[Negritas Sergiu]

I reproduced the issue on 65.0a1 on Linux (18.04LTS) and it's fixed on 69.0b13

Comment 13

[Cristian Comorasu, QA [:ccomorasu], Release Desktop QA]

(In reply to Negritas Sergiu from comment #12)

I reproduced the issue on 65.0a1 on Linux (18.04LTS) and it's fixed on 69.0b13

Hello Sergiu!
Can you please give more details?

Comment 14

[Negritas Sergiu]

(In reply to Cristian Comorasu, QA [:ccomorasu], Release Desktop QA from comment #13)

(In reply to Negritas Sergiu from comment #12)

I reproduced the issue on 65.0a1 on Linux (18.04LTS) and it's fixed on 69.0b13

Hello Sergiu!
Can you please give more details?

Following the STR from the description, I reproduced this issue using Fx 65.0a1(2018-11-29) on Ubuntu 18.04 LTS.
I can confirm this issue is fixed, I verified using Fx 69.0b13 on the same environment.

Comment 15

[Cristian Comorasu, QA [:ccomorasu], Release Desktop QA]

Awesome, thank you!