151111 - Support nsIAccessibleTable in MAI (Mozilla Atk Implementation)

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Bolian Yin]

Comment 1

[Bolian Yin]

Attachment: patch_v1

Comment 2

[Kyle Yuan]

cc pete for r=

Comment 3

[Bolian Yin]

Attachment: patch_v2

comments in bug 151133 hold here

Comment 4

[Pete Zha]

Comment on attachment 89220 [details] [diff] [review]
patch_v2

1)
>+MaiWidget*
>+MaiInterfaceTable::GetSummary()
>+{
>+    /* ??? in nsIAccessibleTable, it returns a nsAString */
>+    return NULL;
>+}
This is because in html table "summary" is just an attribute of the table
element.
For example: <table summary="abc"></table>
So, I can't make it to an accessible object since there is no domNode for it.

2)
+    /* ??? when the new one get freed? */
+    MaiWidget *maiObj = new MaiWidget(accHeader);
+    return maiObj;
I think the caller will free them...

3)
+gint
+MaiInterfaceTable::GetSelectedColumns(gint **aSelected)
+{
+    return 0;
+}
+
+gint
+MaiInterfaceTable::GetSelectedRows(gint **aSelected)
+{
+    return 0;
+}
Why these two functions return zero?

Others seems OK for me.
r=pete

Comment 5

[Bolian Yin]

Thanks, pete
for the object free problem, see bug 154327.  For the two "return 0" function, I
want to delay the implementation due to some unclear problem. 

Comment 6

[Aaron Leventhal]

r=aaronl

I should mention that it is possible to support the HTML summary attribute as
it's own nsIAccessible if you want. You would have to override
GetAccFirstChild(), GetAccLastChild(), GetAccChildCount(). We have overriden
those methods in a few places already. Just thought I would mention it.

Comment 7

[Pete Zha]

>You would have to overrideGetAccFirstChild(), GetAccLastChild(),
>GetAccChildCount(). We have overriden
>those methods in a few places already. Just thought I would mention it.
aaronl, Did you mean we can create an instance of nsIAccessible which
GetAccFirstChild(), GetAccLastChild() return null and GetAccChildCount() return
0, and GetAccValue() or GetAccName() return the summary attribute?

Comment 8

[Aaron Leventhal]

I just wanted to point out that you can add an nsIAccessible anywhere in the
accessible tree, even if there is no dom node, by overriding the
GetAccFirstChild(), GetAccLastChild() and GetAccChildCount() methods. That is
how we did our HTML areas as children of the image, as IE does for MSAA.

Comment 9

[Bolian Yin]

This bug has been checked in.
It is not in the default build and we need it to do later work. Further
comments, review, and super-review is still welcome, I will file new bug if
needed. Thanks for everyone.

Comment 10

[Bolian Yin]

=>Fix

Comment 11

[Bolian Yin]

=>Fix