1511121 - [wpt-sync] Sync PR 14298 - [Background Fetch] Remove records_ from BackgroundFetchRegistration.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 14298 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14298
Details from upstream follow.

Mugdha Lakhani <[e-mail]> wrote:
>  [Background Fetch] Remove records_ from BackgroundFetchRegistration.
>  
>  This had been introduced to simplify access to active fetches, but has
>  the following issues:
>  1. It makes match() and matchAll() inconsistent with Cache API's match()
>  and matchAll(), which return new independently-consumable response(s) every
>  time they're called.
>  2. It breaks retries for responses, when downloading from a server that
>  doesn't support resuming of downloads.
>  
>  For details, see
>  https://docs.google.com/document/d/1CrbWrnnshhyp_SfiAeuODpnQX36GK3Bsi19rXQGez6Q/edit?usp=sharing
>  
>  The CL also updates the WPT test accordingly.
>  
>  Bug: 875201
>  Change-Id: I2c33717cbee36f0d707e814506c0bae9b5a4f31f
>  Reviewed-on: https://chromium-review.googlesource.com/1355121
>  WPT-Export-Revision: 3cb773540eaff5a69b97f6a10efd273a3d48bbe8

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 14298 applied with additional changes from upstream: 12720fdc8914deec3e7cc627036a26217cc1e908

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7e5c5aa0f65c51392c32ffa70fc2c105a63dc02

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=74b0b411fe99fc98973b53362841fb189aab9146

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef10de98b62684616bcd7504bcda573bc2ad8504

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cad240709096dd630056e06d840953e9837d43e

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=1be0cf30afbfdf71d54637fde5cd87fd27bee777

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Ran 1 tests and 16 subtests
OK     : 1
FAIL   : 16

New tests that have failures or other problems:
/background-fetch/fetch.https.window.html
    Matching multiple times on the same request works as expected.: FAIL

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fcab4ceeb0fd10df489a851e5dc883814790d290

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9065c259be4d
[wpt PR 14298] - [Background Fetch] Remove records_ from BackgroundFetchRegistration., a=testonly

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9065c259be4d