Add support for template-string-based codegen to ipdl's lower.py

RESOLVED FIXED in Firefox 69

Status

()

enhancement
P2
normal
RESOLVED FIXED
7 months ago
27 days ago

People

(Reporter: Nika, Assigned: Nika)

Tracking

unspecified
mozilla69
Points:
---

Firefox Tracking Flags

(firefox69 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

This approach augments the AST used to generate IPDL's C++ code to support template string based substitutions. This is somewhat complicated by the way that the AST & ast codegen currently functions, but appears to function well.

The logic for these new entrypoints are implemented in code.py, and the outputted AST tries to be fairly straightforward, although it doesn't try to optimize itself for simplicity.

Updated

6 months ago
Priority: -- → P2
Attachment #9028769 - Attachment is obsolete: true
Attachment #9028770 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → INACTIVE
Attachment #9028770 - Attachment is obsolete: false
Attachment #9028769 - Attachment is obsolete: false
Attachment #9028769 - Attachment description: Bug 1511161 - Part 1: Initial implementation of new codegen features, → Bug 1511161 - Part 1: Add new Code object to IPDL codegen,
Attachment #9028770 - Attachment is obsolete: true
Status: RESOLVED → REOPENED
Resolution: INACTIVE → ---

Comment 4

28 days ago
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ba0de671a6c4
Part 1: Add new Code object to IPDL codegen, r=froydnj
https://hg.mozilla.org/integration/autoland/rev/b5b964c5db52
Part 2: Use Code throughout IPDL codegen, r=froydnj

Comment 5

27 days ago
bugherder
Status: REOPENED → RESOLVED
Closed: 3 months ago27 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.