Closed Bug 1511161 Opened 3 years ago Closed 2 years ago

Add support for template-string-based codegen to ipdl's lower.py

Categories

(Core :: IPC, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: nika, Assigned: nika)

References

Details

Attachments

(2 files, 1 obsolete file)

This approach augments the AST used to generate IPDL's C++ code to support template string based substitutions. This is somewhat complicated by the way that the AST & ast codegen currently functions, but appears to function well.

The logic for these new entrypoints are implemented in code.py, and the outputted AST tries to be fairly straightforward, although it doesn't try to optimize itself for simplicity.
Priority: -- → P2
Attachment #9028769 - Attachment is obsolete: true
Attachment #9028770 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INACTIVE
Attachment #9028770 - Attachment is obsolete: false
Attachment #9028769 - Attachment is obsolete: false
Attachment #9028769 - Attachment description: Bug 1511161 - Part 1: Initial implementation of new codegen features, → Bug 1511161 - Part 1: Add new Code object to IPDL codegen,
Attachment #9028770 - Attachment is obsolete: true
Status: RESOLVED → REOPENED
Resolution: INACTIVE → ---
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ba0de671a6c4
Part 1: Add new Code object to IPDL codegen, r=froydnj
https://hg.mozilla.org/integration/autoland/rev/b5b964c5db52
Part 2: Use Code throughout IPDL codegen, r=froydnj
Status: REOPENED → RESOLVED
Closed: 3 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.