Port bug 1498448: Migrate Certificate Manager Dialog to use fluent for localization

RESOLVED FIXED in Thunderbird 65.0

Status

enhancement
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 65.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

We use strings from certManager.dtd in chat/content/account.xml and mailnews/extensions/newsblog/content/feed-subscriptions.xul. These need to be changed to use the fluent strings.
This works for me. Without patch, TB closes when I try to open the subscribe dialog and the Chat account dialog is almost empty.

With patch, the strings aren't shown for me in the dialogs. But when I inspect them with the inspector, I see them.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9028773 - Flags: review?(jorgk)
Comment on attachment 9028773 [details] [diff] [review]
1511170-cert-manager-fluent.patch

Review of attachment 9028773 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Richard Marti (:Paenglab) from comment #1)
> This works for me. Without patch, TB closes when I try to open the subscribe
> dialog and the Chat account dialog is almost empty.
That doesn't happen for me. For feed subscription, the label is on a collapsed button I've never seen, and in the chat AM I can't see that "Add Exception" button either.

::: chat/content/account.xml
@@ +2,5 @@
>  <!-- This Source Code Form is subject to the terms of the Mozilla Public
>     - License, v. 2.0. If a copy of the MPL was not distributed with this
>     - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
>  
> +<!DOCTYPE binding SYSTEM "chrome://chat/locale/accounts.dtd">

This doesn't look right. There is DOCTYPE bindings. Why not just remove the certManagerDTD line?
I'll land this now. The strings are gone, so time to act.
Attachment #9028773 - Attachment is obsolete: true
Attachment #9028773 - Flags: review?(jorgk)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/57a3525213c4
Port bug 1498448: Migrate Certificate Manager Dialog to use fluent for localization. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
(In reply to Jorg K (GMT+1) from comment #2)
> Comment on attachment 9028773 [details] [diff] [review]
> 1511170-cert-manager-fluent.patch
> 
> Review of attachment 9028773 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> (In reply to Richard Marti (:Paenglab) from comment #1)
> > This works for me. Without patch, TB closes when I try to open the subscribe
> > dialog and the Chat account dialog is almost empty.
> That doesn't happen for me. For feed subscription, the label is on a
> collapsed button I've never seen, and in the chat AM I can't see that "Add
> Exception" button either.

You haven't deleted the certManager.dtd in your obj-dir.
You need to log in before you can comment on or make changes to this bug.