Perma dom/base/test/test_window_define_nonconfigurable.html | Should return false when 'failing' to define non-configurable property via Object.defineProperty. - got [object Window], expected false when Gecko 65 merges to Beta on 2018-12-03

VERIFIED FIXED in Firefox 65

Status

()

defect
P2
normal
VERIFIED FIXED
6 months ago
2 months ago

People

(Reporter: apavel, Assigned: bzbarsky)

Tracking

Trunk
mozilla66
Points:
---

Firefox Tracking Flags

(thunderbird_esr60 unaffected, geckoview64 unaffected, firefox-esr60 unaffected, firefox63 unaffected, firefox64 unaffected, firefox65+ fixed, firefox66 fixed)

Details

(Whiteboard: [stockwell needswork:owner])

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

6 months ago
[Tracking Requested - why for this release]:

Central as Beta simulation:

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=214692438&revision=77fd51aab06800d22a8c6f642df2a7c37b727972

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=214692438&repo=try&lineNumber=1748

[task 2018-11-29T22:17:07.904Z] 22:17:07     INFO -  394 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Should have a property 'nosuchprop4' now
[task 2018-11-29T22:17:07.904Z] 22:17:07     INFO -  395 INFO TEST-UNEXPECTED-FAIL | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop4' should be configurable - got false, expected true
[task 2018-11-29T22:17:07.904Z] 22:17:07     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:320:5
[task 2018-11-29T22:17:07.905Z] 22:17:07     INFO -      @dom/base/test/test_window_define_nonconfigurable.html:57:3
[task 2018-11-29T22:17:07.905Z] 22:17:07     INFO -  396 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop4' should be readonly
[task 2018-11-29T22:17:07.905Z] 22:17:07     INFO -  397 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop4' should have the right value
[task 2018-11-29T22:17:07.905Z] 22:17:07     INFO -  398 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Should be able to Reflect.defineProperty with default configurability
[task 2018-11-29T22:17:07.905Z] 22:17:07     INFO -  399 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Should have a property 'nosuchprop5' now
[task 2018-11-29T22:17:07.905Z] 22:17:07     INFO -  400 INFO TEST-UNEXPECTED-FAIL | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop5' should be configurable - got false, expected true
[task 2018-11-29T22:17:07.905Z] 22:17:07     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:320:5
[task 2018-11-29T22:17:07.906Z] 22:17:07     INFO -      @dom/base/test/test_window_define_nonconfigurable.html:68:3
[task 2018-11-29T22:17:07.906Z] 22:17:07     INFO -  401 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop5' should be readonly
[task 2018-11-29T22:17:07.906Z] 22:17:07     INFO -  402 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop5' should have the right value
[task 2018-11-29T22:17:07.906Z] 22:17:07     INFO -  403 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Should be able to Reflect.defineProperty if configurable
[task 2018-11-29T22:17:07.906Z] 22:17:07     INFO -  404 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Should have a property 'nosuchprop6' now
[task 2018-11-29T22:17:07.906Z] 22:17:07     INFO -  405 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop6' should be configurable
[task 2018-11-29T22:17:07.906Z] 22:17:07     INFO -  406 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop6' should be readonly
[task 2018-11-29T22:17:07.907Z] 22:17:07     INFO -  407 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop6' should have the right value
[task 2018-11-29T22:17:07.907Z] 22:17:07     INFO -  408 INFO TEST-OK | dom/base/test/test_window_define_nonconfigurable.html | took 1842ms


This appears to be from bug 1178639, Boris can you take a look?
Flags: needinfo?(bzbarsky)
Yep.  The code changes from bug 1178639 are only enabled on nightly for now.

The simplest thing might be to back out the test changes from bug 1178639 on beta after the merge.

If we really want to avoid that, I can try to figure out a way to have the tests detect which channel they're on and deal accordingly.  Please let me know.
Flags: needinfo?(bzbarsky) → needinfo?(apavel)
(Reporter)

Comment 2

6 months ago
Boris, can't you make a backout  for the test parts only?
I assume backing out after the merge is okay too, however, better redirect that to Aryx.
Flags: needinfo?(apavel) → needinfo?(aryx.bugmail)
> Boris, can't you make a backout  for the test parts only?

You mean on nightly?  No, because then the tests would fail on nightly.

Basically, nightly and beta have very different behavior for the moment.  The tests used to be testing the beta behavior; now they are testing the nightly behavior.

If the question was whether I can post the backout patch in this bug, I sure can.
(Reporter)

Comment 4

6 months ago
Yes, sorry for not being explicit enough. Callek suggested that this might be an easier option.
Posted patch Backout diff (obsolete) — Splinter Review
(In reply to Andreea Pavel [:apavel] from comment #2)
> Boris, can't you make a backout  for the test parts only?
> I assume backing out after the merge is okay too, however, better redirect
> that to Aryx.
We can do it for 65 beta like this but that means it would have to be backed out everytime a new Gecko version branches to beta.
Flags: needinfo?(aryx.bugmail)
Keywords: leave-open
> but that means it would have to be backed out everytime a new Gecko version branches to beta.

Yes... I am hoping that in the next nightly cycle we will figure out whether we can ship this.
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Priority: -- → P2
This is permafailing on Beta for over a week now. What can we do to stop the bleeding there?
Flags: needinfo?(bzbarsky)
Posted patch Additional backout patch (obsolete) — Splinter Review
Why didn't someone tell me the backout didn't fully fix the test?  :(

This needs to be landed on beta too.
Flags: needinfo?(bzbarsky)
Also, why are people starring non-intermittent stuff as intermittents?  :(
Whiteboard: [stockwell needswork:owner] → [stockwell needswork:owner][checkin-needed-beta]
Comment hidden (Intermittent Failures Robot)
Whiteboard: [stockwell needswork:owner][checkin-needed-beta] → [stockwell needswork:owner]
> we've imported the backout in the beta sim, however this is still failing

That push includes the first patch in this bug, but not the second one.  You need both.

If it would help, I can merge the two patches into one for you...
Flags: needinfo?(bzbarsky)
(Reporter)

Comment 19

5 months ago
Boris, for me qimport does not add both patches:

https://irccloud.mozilla.com/file/UQZBM0DZ/image.png

Please merge them as one. Thank you.
Attachment #9028851 - Attachment is obsolete: true
Attachment #9030628 - Attachment is obsolete: true
Comment hidden (Intermittent Failures Robot)
(Reporter)

Comment 23

5 months ago
Boris should we land this on inbound ?
Flags: needinfo?(bzbarsky)
If you do, inbound will go orange.  Again, the point is that nightly and beta/release have different behavior here for the moment.  The test is testing for the nightly behavior; when beta branches the test needs to be changed to test for the beta behavior, which is the backout patch here.
Flags: needinfo?(bzbarsky)
(Reporter)

Comment 25

5 months ago
Oh, thanks for clarifying this Boris. I assumed it works like the other bugs and it's fixed once it gets to central.
Once we decide that we're shipping this non-configurability behavior, we can
remove these bits.
(Assignee)

Updated

4 months ago
Keywords: leave-open

Comment 27

4 months ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/199b64bd4ead
Add checks for RELEASE_OR_BETA for now.  r=peterv

Comment 28

4 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Assignee: nobody → bzbarsky
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.