1511232 - Perma dom/base/test/test_window_define_nonconfigurable.html | Should return false when 'failing' to define non-configurable property via Object.defineProperty. - got [object Window], expected false when Gecko 65 merges to Beta on 2018-12-03

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Andreea Pavel [:apavel]]

[Tracking Requested - why for this release]:

Central as Beta simulation:

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=214692438&revision=77fd51aab06800d22a8c6f642df2a7c37b727972

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=214692438&repo=try&lineNumber=1748

[task 2018-11-29T22:17:07.904Z] 22:17:07     INFO -  394 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Should have a property 'nosuchprop4' now
[task 2018-11-29T22:17:07.904Z] 22:17:07     INFO -  395 INFO TEST-UNEXPECTED-FAIL | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop4' should be configurable - got false, expected true
[task 2018-11-29T22:17:07.904Z] 22:17:07     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:320:5
[task 2018-11-29T22:17:07.905Z] 22:17:07     INFO -      @dom/base/test/test_window_define_nonconfigurable.html:57:3
[task 2018-11-29T22:17:07.905Z] 22:17:07     INFO -  396 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop4' should be readonly
[task 2018-11-29T22:17:07.905Z] 22:17:07     INFO -  397 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop4' should have the right value
[task 2018-11-29T22:17:07.905Z] 22:17:07     INFO -  398 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Should be able to Reflect.defineProperty with default configurability
[task 2018-11-29T22:17:07.905Z] 22:17:07     INFO -  399 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Should have a property 'nosuchprop5' now
[task 2018-11-29T22:17:07.905Z] 22:17:07     INFO -  400 INFO TEST-UNEXPECTED-FAIL | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop5' should be configurable - got false, expected true
[task 2018-11-29T22:17:07.905Z] 22:17:07     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:320:5
[task 2018-11-29T22:17:07.906Z] 22:17:07     INFO -      @dom/base/test/test_window_define_nonconfigurable.html:68:3
[task 2018-11-29T22:17:07.906Z] 22:17:07     INFO -  401 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop5' should be readonly
[task 2018-11-29T22:17:07.906Z] 22:17:07     INFO -  402 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop5' should have the right value
[task 2018-11-29T22:17:07.906Z] 22:17:07     INFO -  403 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Should be able to Reflect.defineProperty if configurable
[task 2018-11-29T22:17:07.906Z] 22:17:07     INFO -  404 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Should have a property 'nosuchprop6' now
[task 2018-11-29T22:17:07.906Z] 22:17:07     INFO -  405 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop6' should be configurable
[task 2018-11-29T22:17:07.906Z] 22:17:07     INFO -  406 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop6' should be readonly
[task 2018-11-29T22:17:07.907Z] 22:17:07     INFO -  407 INFO TEST-PASS | dom/base/test/test_window_define_nonconfigurable.html | Property 'nosuchprop6' should have the right value
[task 2018-11-29T22:17:07.907Z] 22:17:07     INFO -  408 INFO TEST-OK | dom/base/test/test_window_define_nonconfigurable.html | took 1842ms


This appears to be from bug 1178639, Boris can you take a look?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Yep.  The code changes from bug 1178639 are only enabled on nightly for now.

The simplest thing might be to back out the test changes from bug 1178639 on beta after the merge.

If we really want to avoid that, I can try to figure out a way to have the tests detect which channel they're on and deal accordingly.  Please let me know.

Comment 2

[Andreea Pavel [:apavel]]

Boris, can't you make a backout  for the test parts only?
I assume backing out after the merge is okay too, however, better redirect that to Aryx.

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Boris, can't you make a backout  for the test parts only?

You mean on nightly?  No, because then the tests would fail on nightly.

Basically, nightly and beta have very different behavior for the moment.  The tests used to be testing the beta behavior; now they are testing the nightly behavior.

If the question was whether I can post the backout patch in this bug, I sure can.

Comment 4

[Andreea Pavel [:apavel]]

Yes, sorry for not being explicit enough. Callek suggested that this might be an easier option.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Backout diff

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Andreea Pavel [:apavel] from comment #2)
> Boris, can't you make a backout  for the test parts only?
> I assume backing out after the merge is okay too, however, better redirect
> that to Aryx.
We can do it for 65 beta like this but that means it would have to be backed out everytime a new Gecko version branches to beta.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/e9b94ebee2e7

Comment 8

[Boris Zbarsky [:bzbarsky]]

> but that means it would have to be backed out everytime a new Gecko version branches to beta.

Yes... I am hoping that in the next nightly cycle we will figure out whether we can ship this.

Comment 9

[Intermittent Failures Robot]

51 failures in 206 pushes (0.248 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-beta: 51

Platform breakdown:
* linux64-devedition: 2
* linux64-nightly: 3
* windows7-32-devedition: 1
* linux64-qr: 1
* windows10-64: 6
* macosx64-devedition: 3
* linux64: 3
* linux32-nightly: 3
* osx-10-10: 3
* linux32-devedition: 3
* android-em-4-3-armv7-api16: 6
* windows10-64-qr: 3
* windows7-32: 3
* windows7-32-nightly: 2
* macosx64-nightly: 3
* windows10-64-devedition: 2
* linux32: 2
* windows10-64-nightly: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1511232&startday=2018-12-03&endday=2018-12-03&tree=all

Comment 10

[Intermittent Failures Robot]

19 failures in 381 pushes (0.05 failures/push) were associated with this bug yesterday.

Repository breakdown:
* try: 19

Platform breakdown:
* android-em-4-3-armv7-api16: 4
* linux64: 6
* linux32: 4
* osx-10-10: 1
* macosx64-nightly: 2
* linux64-qr: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1511232&startday=2018-12-06&endday=2018-12-06&tree=all

Comment 11

[Intermittent Failures Robot]

70 failures in 1862 pushes (0.038 failures/push) were associated with this bug in the last 7 days.

This is the #8 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* try: 19
* mozilla-beta: 51

Platform breakdown:
* linux32-devedition: 3
* linux32: 6
* windows10-64-nightly: 2
* macosx64-nightly: 5
* macosx64-devedition: 3
* linux64-nightly: 3
* windows10-64-qr: 3
* windows10-64: 6
* windows7-32: 3
* windows7-32-devedition: 1
* osx-10-10: 4
* android-em-4-3-armv7-api16: 10
* linux64-qr: 3
* linux32-nightly: 3
* linux64: 9
* linux64-devedition: 2
* windows7-32-nightly: 2
* windows10-64-devedition: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1511232&startday=2018-12-03&endday=2018-12-09&tree=all

Comment 12

[Ryan VanderMeulen [:RyanVM]]

This is permafailing on Beta for over a week now. What can we do to stop the bleeding there?

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: Additional backout patch

Why didn't someone tell me the backout didn't fully fix the test?  :(

This needs to be landed on beta too.

Comment 14

[Boris Zbarsky [:bzbarsky]]

Also, why are people starring non-intermittent stuff as intermittents?  :(

Comment 15

[Intermittent Failures Robot]

26 failures in 445 pushes (0.058 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-beta: 26

Platform breakdown:
* windows10-64-qr: 1
* linux64-qr: 1
* linux32-nightly: 1
* windows7-32: 1
* windows10-64-nightly: 1
* linux32-devedition: 1
* macosx64-devedition: 1
* linux64: 3
* windows7-32-devedition: 1
* windows10-64: 1
* windows7-32-nightly: 1
* linux64-devedition: 1
* android-em-4-3-armv7-api16: 7
* linux32: 2
* macosx64-nightly: 1
* windows10-64-devedition: 1
* linux64-nightly: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1511232&startday=2018-12-11&endday=2018-12-11&tree=all

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a13db67049a2

Comment 17

[Andreea Pavel [:apavel]]

Boris, we've imported the backout in the beta sim, however this is still failing. 

https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=5cf5868e0522ed53bd67a143abc3c55b0a7cb746&selectedJob=217006339

Comment 18

[Boris Zbarsky [:bzbarsky]]

> we've imported the backout in the beta sim, however this is still failing

That push includes the first patch in this bug, but not the second one.  You need both.

If it would help, I can merge the two patches into one for you...

Comment 19

[Andreea Pavel [:apavel]]

Boris, for me qimport does not add both patches:

https://irccloud.mozilla.com/file/UQZBM0DZ/image.png

Please merge them as one. Thank you.

Comment 20

[Boris Zbarsky [:bzbarsky]]

Attachment: Unified backout patch

Comment 21

[Intermittent Failures Robot]

26 failures in 2485 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-beta: 26

Platform breakdown:
* linux32: 2
* linux32-nightly: 1
* linux64-qr: 1
* windows10-64: 1
* linux64-nightly: 1
* linux32-devedition: 1
* macosx64-devedition: 1
* windows7-32: 1
* macosx64-nightly: 1
* linux64-devedition: 1
* windows10-64-devedition: 1
* windows10-64-nightly: 1
* windows10-64-qr: 1
* linux64: 3
* windows7-32-devedition: 1
* android-em-4-3-armv7-api16: 7
* windows7-32-nightly: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1511232&startday=2018-12-10&endday=2018-12-16&tree=all

Comment 22

[Andreea Pavel [:apavel]]

We've imported the backout and the failures do not appear anymore: 

https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=e6b06a78bc5893afa5aaffeab4a9e6b5aab9b196&group_state=expanded

Comment 23

[Andreea Pavel [:apavel]]

Boris should we land this on inbound ?

Comment 24

[Boris Zbarsky [:bzbarsky]]

If you do, inbound will go orange.  Again, the point is that nightly and beta/release have different behavior here for the moment.  The test is testing for the nightly behavior; when beta branches the test needs to be changed to test for the beta behavior, which is the backout patch here.

Comment 25

[Andreea Pavel [:apavel]]

Oh, thanks for clarifying this Boris. I assumed it works like the other bugs and it's fixed once it gets to central.

Comment 26

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1511232. Add checks for RELEASE_OR_BETA for now. r=peterv

Once we decide that we're shipping this non-configurability behavior, we can
remove these bits.

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/199b64bd4ead
Add checks for RELEASE_OR_BETA for now.  r=peterv

Comment 28

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/199b64bd4ead

Comment 29

[Cosmin Sabou [:CosminS]]

This no longer appears on beta simulations. https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=c0732327e39ba5e2a2ddc9a71bbb6cef6f8c20a9