1511237 - Hold a weak reference to TabParent in nsDocShell

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement, P2)

Description

[Nika Layzell [:nika] (ni? for response)]

Currently the object is fetched by calling do_GetInterface on the tree root. Unfortunately, the tree root is nulled out when a DocShell's owning document is put into the BFCache, meaning that TabChild becomes inaccessible.

This patch changes DocShell to instead hold a nsWeakPtr reference to the TabChild which is used for GetTabChild rather than going through the tree root.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1511237 - Store a TabChild reference in cached docshells,

Comment 2

[Neha Kochar [:neha]]

Nika, should this block bug 1469429?

Comment 3

[Nika Layzell [:nika] (ni? for response)]

no, this is part of me trying to land my PWindowGlobal patches, so it should block those.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/788d4d999843
Store a TabChild reference in cached docshells, r=bzbarsky, r=smaug

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc7076b4b610
Store a TabChild reference in cached docshells, r=bzbarsky, r=smaug

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/dc7076b4b610