Closed Bug 1511237 Opened 3 years ago Closed 3 years ago
Hold a weak reference to Tab
Parent in ns Doc Shell
47 bytes, text/x-phabricator-request
|Details | Review|
Currently the object is fetched by calling do_GetInterface on the tree root. Unfortunately, the tree root is nulled out when a DocShell's owning document is put into the BFCache, meaning that TabChild becomes inaccessible. This patch changes DocShell to instead hold a nsWeakPtr reference to the TabChild which is used for GetTabChild rather than going through the tree root.
Nika, should this block bug 1469429?
no, this is part of me trying to land my PWindowGlobal patches, so it should block those.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/788d4d999843 Store a TabChild reference in cached docshells, r=bzbarsky, r=smaug
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dc7076b4b610 Store a TabChild reference in cached docshells, r=bzbarsky, r=smaug
You need to log in before you can comment on or make changes to this bug.