Closed
Bug 1511258
Opened 6 years ago
Closed 6 years ago
Fix mach clang-format with -assume-filename
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox65 fixed)
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(1 file)
I tried to use it for a git merge driver and it broke horribly. Patch incoming.
|
Assignee | |
Comment 1•6 years ago
|
||
I tried to use it to write a git merge driver. Git merge drivers receive garbage names like .merge_file_EE7Nlw. That's clearly not a useful file name to give to _generate_path_list. Instead, give the path name to be assumed, which is actually the right path name to use.
|
||
Updated•6 years ago
|
Attachment #9028853 -
Attachment description: Fix ./mach clang-format -a so it actually does something useful. → Fix ./mach clang-format -a so it doesn't make assumptions about the incoming file name.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b9d92fc39034 Fix ./mach clang-format -a so it doesn't make assumptions about the incoming file name. r=Ehsan
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b9d92fc39034
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
|
||
Updated•5 years ago
|
Target Milestone: Firefox 65 → mozilla65
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•