1511282 - Bugfiler throws some uncaught js errors

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

The bugfiler throws a couple jr errors that don't get caught anywhere:
Upon opening the bugfiler for a test failure that doesn't get mozbuild metadata automatically (happens more and more often these days, see bug 1354791), if you click the "Find Product" button without entering any search terms, an error will be thrown because `firstRequest.data is undefined` (error gets obscured on production, something like `r is undefined` iirc).

Second, upon opening the bugfiler for a test failure that doesn't get mozbuild metadata automatically, if you click the "Submit Bug" button with no product selected, a js error will be thrown (`_this$state2 is undefined`), and you won't see the TH notify() saying you need to select a product before submitting the bug, as it won't trigger the notification because of that error.

First problem's easy to fix, just make sure firstRequest.data is defined before trying to do more work with it.

Second problem is more confusing to me. I think there's some race condition where not all of the parts of this.state have been defined at the point where the submitFiler() function is triggered. I'm not entirely sure what can be done about that. Maybe I can instead disable the Submit button until a product is selected (and add a tooltip to the disabled Submit button explaining that)? That might be easier than re-working the whole thing to make sure everything's in place before we try to submit the bug without the product selected.

Thoughts, Cam?

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4330

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 9028873 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4330

This seems to fix the immediate problems for me, though I'd really prefer a better solution to the submit button's brokenness. I just don't know react well enough to do that without some hand holding. :)

Comment 3

[Cameron Dawson [:camd]]

Comment on attachment 9028873 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4330

Just asking for a couple small changes.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 9028873 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4330

Comments addressed. Thanks for looking at this!

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/7f320cb93ff01676d4d2d9ec89b875e2ca438d79
Bug 1511282 - Catch some errors in the bugfiler so it doesn't break in some cases (#4330)