Closed
Bug 1511305
Opened 5 years ago
Closed 5 years ago
[wpt-sync] Sync PR 14302 - [css-contain][css-grid] Support size containment on grid containers
Categories
(Core :: CSS Parsing and Computation, defect, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla69
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 14302 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/14302 Details from upstream follow. Manuel Rego Casasnovas <rego@igalia.com> wrote: > [css-contain][css-grid] Support size containment on grid containers > > We were always sizing grid containers with "contain: size" as 0x0. > However this is wrong as discussed on the following GitHub issue: > https://github.com/w3c/csswg-drafts/issues/2804 > > To do this we add a new method GridContainerSizeWithoutItems() > that returns the size based only on the grid container style. > As it should has the same size than the same grid container > without contents. > > For widths the change is pretty simple > in LayoutGrid::ComputeIntrinsicLogicalWidths(). > For heights we don't have a phase to compute the intrinsic size > so apart from the changes in LayoutGrid::UpdateBlockLayout() > we need some extra checks in LayoutBox too. > > There is a minor change in test contain-size-grid-002.html, > because after this patch it was not passing yet due to some overflow > that is unrelated to the purpose of the test. > > BUG=855261 > TEST=external/wpt/css/css-contain/contain-size-grid-002.html > TEST=external/wpt/css/css-contain/contain-size-grid-003.html > > Change-Id: I4d0fd417183068518070721afde84efdbfe1fcb4 > Reviewed-on: https://chromium-review.googlesource.com/1355923 > WPT-Export-Revision: 893d02885a06568eb64665401939bbc6f1b01c7b
Assignee | ||
Updated•5 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Assignee | ||
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=1bcedb5a3a21e48b97e224861b6a8a57fcccf723
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6306482703beeafdf10c1fbef3a7bef30144cb44
Assignee | ||
Comment 3•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=b731a683b12ef9d47c67a4f36e7bd0b73acaf724
Assignee | ||
Comment 4•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d56757a4edc452e4fb3bbb45c4947574b04c64ea
Comment 5•5 years ago
|
||
Changing this from enhancement to defect. Doing (additional) optimizations when containment in turned on would be an enhancement, but containment needs to have the specified effects as a matter of correctness. If it doesn't authors may start (accidentally) rely on the incorrect behavior, and then we won't be able to introduce optimizations later on.
Type: enhancement → defect
Assignee | ||
Comment 6•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=88f212fb81bd62d7ebd5c9a924fdabccce9f0da1
Assignee | ||
Comment 7•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=e309f22d1de8097a7bb66d153c41ae64f0db2cd0
Assignee | ||
Comment 8•5 years ago
|
||
Failed to get results from try push
Assignee | ||
Comment 9•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=82e49c8e659c7531c06ec7984effe499c88d78d0
Comment 10•5 years ago
|
||
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/393b6eaf4a58 [wpt PR 14302] - [css-contain][css-grid] Support size containment on grid containers, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/7e5996eff019 [wpt PR 14302] - Update wpt metadata, a=testonly
Comment 11•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/393b6eaf4a58
https://hg.mozilla.org/mozilla-central/rev/7e5996eff019
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in
before you can comment on or make changes to this bug.
Description
•