Add tests to disable/re-enable and delete/bring flexbox and grid patch

ASSIGNED
Assigned to

Status

P2
normal
ASSIGNED
4 months ago
2 months ago

People

(Reporter: miker, Assigned: miker)

Tracking

(Depends on: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Bug 1509460 stopped disable/re-enable and delete/bring back from bringing the flexbox and grid highlighters back by freeing up the highlighters when this happened.

Unfortunately, the tests have multiple issues with editing the rule view properties so we have broken out the tests into this bug.
Try is failing on debug builds.

Comment 6

3 months ago
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1046da966669
Add tests to disable/re-enable and delete/bring flexbox and grid patch r=gl
Backed out changeset 1046da966669 (bug 1511334) for devtools failures in devtools/client/inspector/flexbox/test/browser_flexbox_toggle_display_change_hides_highlighter.js

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=215978882&repo=autoland&lineNumber=58319

21:06:13     INFO - GECKO(3324) | --DOMWINDOW == 47 (00895800) [pid = 2364] [serial = 395] [outer = 00000000] [url = about:blank]
21:06:13     INFO - GECKO(3324) | --DOMWINDOW == 4 (079E5800) [pid = 3060] [serial = 45] [outer = 00000000] [url = about:blank]
21:06:13     INFO - Removing tab.
21:06:13     INFO - Waiting for event: 'TabClose' on [object XULElement].
21:06:13     INFO - Got event: 'TabClose' on [object XULElement].
21:06:13     INFO - Tab removed and finished closing
21:06:13     INFO - GECKO(3324) | --DOMWINDOW == 12 (082D9000) [pid = 2340] [serial = 74] [outer = 00000000] [url = about:blank]
21:06:13     INFO - GECKO(3324) | --DOMWINDOW == 11 (0B3BF800) [pid = 2340] [serial = 75] [outer = 00000000] [url = http://example.com/browser/devtools/client/inspector/flexbox/test/doc_flexbox_text_nodes.html]
21:06:13     INFO - GECKO(3324) | --DOMWINDOW == 10 (0B3C3C00) [pid = 2340] [serial = 71] [outer = 00000000] [url = about:blank]
21:06:13     INFO - GECKO(3324) | --DOMWINDOW == 9 (0B3C5000) [pid = 2340] [serial = 72] [outer = 00000000] [url = http://example.com/browser/devtools/client/inspector/flexbox/test/doc_flexbox_specific_cases.html]
21:06:13     INFO - GECKO(3324) | --DOMWINDOW == 8 (00F6BC00) [pid = 2340] [serial = 68] [outer = 00000000] [url = about:blank]
21:06:13     INFO - GECKO(3324) | --DOMWINDOW == 7 (082D9400) [pid = 2340] [serial = 69] [outer = 00000000] [url = data:text/html;charset=utf-8,%0A%20%20%3Cstyle%3E%0A%20%20%20%20%23container%20%7B%0A%20%20%20%20%20%20display%3A%20flex%3B%0A%20%20%20%20%7D%0A%20%20%3C%2Fstyle%3E%0A%20%20%3Cdiv%20id%3D%22container%22%3E%0A%20%20%20%20%3Cdiv%20id%3D%22item%22%3E%3C%2Fdiv%3E%0A%20%20%3C%2Fdiv%3E%0A]
21:06:13     INFO - GECKO(3324) | --DOMWINDOW == 6 (0E208000) [pid = 2340] [serial = 66] [outer = 00000000] [url = http://example.com/browser/devtools/client/inspector/flexbox/test/doc_flexbox_CSS_property_with_!important.html]
21:06:13     INFO - GECKO(3324) | --DOCSHELL 185C9000 == 11 [pid = 2364] [id = {78c62230-f406-46f6-8add-2a7b955d9a3e}]
21:06:13     INFO - GECKO(3324) | --DOMWINDOW == 46 (1B3271C0) [pid = 2364] [serial = 427] [outer = 00000000] [url = about:blank]
21:06:13     INFO - GECKO(3324) | --DOCSHELL 00893000 == 10 [pid = 2364] [id = {ec7d6c64-37d2-4815-b1ea-6e9b28c20c83}]
21:06:13     INFO - GECKO(3324) | --DOMWINDOW == 45 (135F1B00) [pid = 2364] [serial = 425] [outer = 00000000] [url = about:blank]
21:06:13     INFO - GECKO(3324) | --DOCSHELL 185C5800 == 9 [pid = 2364] [id = {a610cb1e-0f41-4a9a-9223-e5e6846e318c}]
21:06:13     INFO - GECKO(3324) | --DOCSHELL 0E404C00 == 8 [pid = 2364] [id = {bf823aff-f1ab-46e2-b1ce-e6ac445422ba}]
21:06:13     INFO - GECKO(3324) | --DOCSHELL 00898000 == 7 [pid = 2364] [id = {cc33c29d-6683-4770-ba23-1444fdf93448}]
21:06:13     INFO - GECKO(3324) | --DOMWINDOW == 44 (0E431480) [pid = 2364] [serial = 396] [outer = 00000000] [url = about:blank]
21:06:13     INFO - GECKO(3324) | --DOMWINDOW == 43 (135EFA80) [pid = 2364] [serial = 405] [outer = 00000000] [url = chrome://devtools/content/inspector/markup/markup.xhtml]
21:06:13     INFO - GECKO(3324) | --DOMWINDOW == 42 (0E77A480) [pid = 2364] [serial = 399] [outer = 00000000] [url = chrome://devtools/content/inspector/index.xhtml]
21:06:13     INFO - GECKO(3324) | MEMORY STAT | vsize 887MB | vsizeMaxContiguous 493MB | residentFast 362MB | heapAllocated 115MB
21:06:13     INFO - TEST-OK | devtools/client/inspector/flexbox/test/browser_flexbox_toggle_display_change_hides_highlighter.js | took 4730ms

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=1046da966669ca17863da3d3cc4619ad8ca54652

Backout:
https://hg.mozilla.org/integration/autoland/rev/2bdc76f2ab94b74ec344bff1c93a4adc711da77b
Flags: needinfo?(mratcliffe)
Maybe we can work around the race condition by emitting an event from onDisplayChange().
Flags: needinfo?(mratcliffe)
Status: NEW → ASSIGNED
You need to log in before you can comment on or make changes to this bug.