1511341 - Add Nextflix to tp6

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement, P2)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This tracks adding Netflix to tp6.

URL: https://www.netflix.com/watch/70279201
Hero: Play button
Account: See FxPerfTest vault in 1password
Profile: Use the FxPerfTest profile in Netflix

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

:vchin please could or someone from your team confirm that you're happy with the URL and hero element?

Comment 2

[Robert Wood [:rwood]]

I would suggest we add Netflix to the existing tp6-6 suite, as that job only has the one page so far (reddit) and a short run time (7-11 min).

Comment 3

[Vicky Chin [:vchin]]

Play button looks good.
How do we currently handle the auto play doorhanger in tests?

Comment 4

[Vicky Chin [:vchin]]

I should clarify play button as the hero element is ok. URL is ok as well.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Vicky Chin [:vchin] from comment #3)
> Play button looks good.
> How do we currently handle the auto play doorhanger in tests?

If we don't already, then we should probably handle this by setting a preference. It looks like the following should work:

name: media.autoplay.default
value: 1

0 = allowed
1 = blocked
2 = prompt (default)

Comment 6

[Florin Strugariu [:Bebe]]

(In reply to Robert Wood [:rwood] from comment #2)
> I would suggest we add Netflix to the existing tp6-6 suite, as that job only
> has the one page so far (reddit) and a short run time (7-11 min).

how wold we handle updating the zip file? Can it be overwritten?

Comment 7

[Florin Strugariu [:Bebe]]

Attachment: Bug 1511341 Add Nextflix to tp6

Comment 8

[Florin Strugariu [:Bebe]]

and recording file:

https://drive.google.com/open?id=1RmMjIw1uEXXHB6BcirfflD_ANCXgIsJ6

Comment 9

[Florin Strugariu [:Bebe]]

Attachment: netflix.png

We have a banner with the enable DRM  notice when we run the test.
Would that affect the results?

Comment 10

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Florin Strugariu [:Bebe] from comment #9)
> Created attachment 9030405 [details]
> netflix.png
> 
> We have a banner with the enable DRM  notice when we run the test.
> Would that affect the results?

I think we should enable DRM for this test, but it's likely that this differs depending on the platform. For example on macOS I get a banner saying "Firefox is installing components needed to play the audio or video on this page. Please try again later". 

You may have some luck setting media.gmp-widevinecdm.visible and media.gmp-widevinecdm.enabled preferences to true. https://searchfox.org/mozilla-central/source/dom/media/eme/MediaKeySystemAccess.cpp#127

Your screenshot also shows a "Netflix site error" message, which we should look into if it's unrelated to the DRM playback.

Comment 11

[Florin Strugariu [:Bebe]]

:rwood can we activate the DRM in our raptor profile?

Comment 12

[Robert Wood [:rwood]]

(In reply to Florin Strugariu [:Bebe] from comment #11)
> :rwood can we activate the DRM in our raptor profile?

If there are prefs required for specific Raptor tests, you can just add a 'preferences' item in the test INI, i.e.:

https://searchfox.org/mozilla-central/rev/3160ddc1f0ab55d230c595366662c62950e5c785/testing/raptor/raptor/tests/raptor-wasm-godot-ion.ini#21

Comment 13

[Florin Strugariu [:Bebe]]

Investigated this:
1. DRM popup can be fixed by adding "media.eme.enabled":true

2. Netflix error it's because of bug 1511029

Comment 14

[Florin Strugariu [:Bebe]]

Updated.
Tested this on firefox and works fine
On chrome I get a mithmprxy crash.
:rwood can you run a test on chrome plase

Comment 15

[Robert Wood [:rwood]]

I haven't tried this yet, but if mitmproxy is crashing when running this with Chrome on your platform then it can't be landed. Suggest upgrading Chrome, or maybe try re-recording the page.

Comment 16

[Florin Strugariu [:Bebe]]

Tried to find a solution to this all day but failed.

My suggestion here is to have only the firefox working tests.

Comment 17

[Florin Strugariu [:Bebe]]

To have  more context on what's happening in Chrome
One request to https://push.prod.netflix.com/ws causes a internal mitmproxy error.

From my finding this is chrome specific.

```
For request https://push.prod.netflix.com/ws found exact replay match
127.0.0.1:43190: GET https://push.prod.netflix.com/ws
[replay]               << 101 Switching Protocols 0b
WebSocket connection closed by client: (status code missing) (message missing), unknown status code
127.0.0.1:43190: clientdisconnect
127.0.0.1:43190: Traceback (most recent call last):
  File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/server.py", line 119, in handle
    root_layer()
  File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/modes/http_proxy.py", line 9, in __call__
    layer()
  File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/tls.py", line 383, in __call__
    layer()
  File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/http1.py", line 72, in __call__
    layer()
  File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/http.py", line 188, in __call__
    if not self._process_flow(flow):
  File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/http.py", line 257, in _process_flow
    return self.handle_regular_connect(f)
  File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/http.py", line 206, in handle_regular_connect
    layer()
  File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/tls.py", line 383, in __call__
    layer()
  File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/http1.py", line 72, in __call__
    layer()
  File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/http.py", line 188, in __call__
    if not self._process_flow(flow):
  File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/http.py", line 420, in _process_flow
    layer()
  File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/websocket.py", line 154, in __call__
    r = tcp.ssl_read_select(conns, 0.1)
  File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/net/tcp.py", line 387, in ssl_read_select
    ] or select.select(rlist, (), (), timeout)[0]
TypeError: argument must be an int, or have a fileno() method.
```

Comment 18

[Dave Hunt [:davehunt] [he/him] ⌚BST]

:bebe if this can be replicated outside of Raptor, please open an issue against mitmproxy

Comment 19

[Robert Wood [:rwood]]

Setting to P2 since this is blocked on Bug 1520448

Comment 20

[Florin Strugariu [:Bebe]]

As we are planning a massive re record. let's include these tests in that process

Comment 21

[Florin Strugariu [:Bebe]]

Attachment: Bug 1511341 Fix Log message when replaing with no-upstream-cert in Raptor

Depends on D34327

Comment 22

[Florin Strugariu [:Bebe]]

Attachment: Bug 1511341 Add Nextflix to tp6

Depends on D34329

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d6a2f0e6b0a
Fix Log message when replaing with no-upstream-cert in Raptor r=perftest-reviewers,AlexandruIonescu
https://hg.mozilla.org/integration/autoland/rev/201d8ae3dbd5
Add Nextflix to tp6 r=perftest-reviewers,igoldan,AlexandruIonescu

Comment 24

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/6d6a2f0e6b0a
https://hg.mozilla.org/mozilla-central/rev/201d8ae3dbd5