Open Bug 1511449 Opened 6 years ago Updated 10 months ago

Reopen in container doesn't close previous tab

Categories

(Firefox :: Tabbed Browser, defect, P5)

Product:
Firefox
Component:
Tabbed Browser
Version:
64 Branch
Type:
defect

Tracking

()

Status:
REOPENED
Tracking Flags:
Tracking Status
firefox83 --- affected

People

(Reporter: sdk, Unassigned)

References

(Blocks 1 open bug)

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

1. Right-click on a tab
2. Choose option "reopen in container"
3. Choose a container


Actual results:

It creates a duplicate tab in the selected container


Expected results:

It should duplicate the tab in the selected container and close the original tab that isn't in the selected container.
Component: Untriaged → Tabbed Browser
Hello,

I wanted to report the downstream bug report for additional context about this issue: https://github.com/mozilla/multi-account-containers/issues/1311

Best Regards
Hi, I want to keep opening the original tab.

Because,  
For example, I have 2 login account business@gmail.com and the other is shopping@gmail.com.
logged in gmail with business@gmail.com in tab A
And then "reopen in container" on tab A > choose shopping > gmail page will opene in new tab B > I can logged in with 2nd account (i.e. shopping@gmail.com).
Then, I can close the tab B when I finish checking shopping. And then I can continue business one.
So this sequence is very useful for me.


If original tab is closed, I must reopen gmail with buziness@gmail.com again after I finish checking shopping.


Sorry my bad English.
Hello,

Makes sense, if you are already in a container, I just wanted to offer a caveat though. If you are not in a container and you wanted to open the page you are on in a container, closing the original would still be preferable. Perhaps, "Reopen in Container Example, close existing" or some other more fancy description.
Or provide a key modifier.
"reopen in container" > chose "shopping" then duplicate in container tab and the close original tab.
"reopen in container" > chose "shopping" with Ctrl Key then duplicate in container tab and not close the original tab.
@Alice0775 Maybe having two containers (business, shopping) would be a better workflow in your use case no? That way, you save the click to open the second account in an other container. It'll also better isolate your data between both account. I mean containers are about creating separate "context" where one container isn't aware (can't access) data in an other container. 

Also, I've opened this issue because the word "reopen" imply that something has been closed before it was reopened. If not, it should be named "open in container".
Okay. I understand.
Blocks: ContextualIdentity
Priority: -- → P5

This intentionally keeps the original tab, to keep the history of the tab (that cannot be copied the new tab, given the context is different).
bug 1376119 has some more info about the reasoning.

IMO renaming the item to something clearer (I'm not sure) sounds fine.

Blocks: 1376119

I think "Duplicate tab in container" or just "Duplicate in container" would better match the intent of the action.

(In reply to Tooru Fujisawa [:arai] from comment #7)

This intentionally keeps the original tab, to keep the history of the tab (that cannot be copied the new tab, given the context is different).
bug 1376119 has some more info about the reasoning.

IMO renaming the item to something clearer (I'm not sure) sounds fine.

Well actually, both "reopen" and "duplicate" should be possible. So, it isn't
just a matter of renaming it.

A better alternative should be to rename "duplicate tab" to "duplicate in container"
and show the list of containers including the actual container. And in "reopen in
container" the list shouldn't contain the actual container and it should close the
previous tab. In that second scenario, it's OK to lose the history since the user
has intentionally decided to transfer the tab to an other container and it wouldn't
make sense to pollute that container with the previous one.

A better alternative should be to rename "duplicate tab" to "duplicate in container"

That would definitely make it clearer what is the intended behavior.

And in "reopen in container" the list shouldn't contain the actual container and it should close the
previous tab. In that second scenario, it's OK to lose the history since the user
has intentionally decided to transfer the tab to an other container and it wouldn't
make sense to pollute that container with the previous one.

This is really the point of this ticket, ideally, it's not a better naming scheme but requesting a change in behavior or enhance the current behavior. I've decided that I want this Tab/Site to be re-opened in this example container. Please, close the previous tab.

The current behavior, is tediously garbage collection, closing the previous useless tab by hand, especially if you are like me who uses 'reopen in container' allot.

Totally second this (@Danny and others proposal): I tend to get a lot of tabs opened. Normally I realize after I already have a lot. I could have been working on Web coding and then have to change to Git or machine learning for example different reasons before coming back again to Web. I then see the "Multi-account container", which I've barely used (see *note1) but then and thought, oh! maybe this could be really useful if I enter "web", "ML" and "git" accounts, then I select all the tabs related to Git so that I can separate them and temporarily hide them, but the result is that all tabs are duplicated, and worse than that, originals are repeated ones are interpolated (oohhh nooo!) so you can't just simply select them all the original at once and delete them...
See pic:
https://1drv.ms/u/s!AiKvtnTf3_aEnmjm8pDSZXVmIT2k

*note1: having multi accounts like google/vivaldi is really important for me but I didn't see "Multi-accounts containers" useful as for very different topics as home/coder/musician I need different bookmarks too. But for not that drastic role changes like webcoder, ML, Git... this could really be useful, if reopening tabs works as mentioned here (also there should be an option to add all this tabs/webpages to a container automatically in bulk -not as per page basis as it is now, but I'd use it if just this first step is incorporated).

Then this use should be communicated in FF welcome or tips pages, so that people realize how convenient it is.

A further step (sometimes things doesn't work if the complete system is not taken into consideration): To separate the above topics and others, apart from using other browsers, inside FF I'm just moving things to a new window and closing Window sessions. I'm seeing that opening a container in a new window doesn't automatically open new tabs in the new container... Opening them with the keyboark Ctrl+'.' then tabs and Enter, is ok yet we are used to a single Ctrl+T keystroke, which is much more convenient and people won't even think about the 'multi-account container' (let alone clicking on it to open a tab). So windows sessions could be helpful. Only if they were more readily accessible and FF didn't just keep the last few opened windows, so that one could totally rely on window sessions... Keeping all sessions could be too much as we sometimes need to just discard/close them. But the MAContainer could help saving those we want so joining both windows sessions and Multi-account containers makes a lot of sense, and it is maybe also require for this to be widely used...

I like Alice0775 White's idea a key modifier (or splitting it into two menu items, "Duplicate in Container" and "Reopen/Move to Container").

It sounds like some users like the duplication behavior, and some of us really want the original tab to close itself (I'm in the second camp). So making both behaviors available would be great.

This is a great idea! Will this change be considered in future versions?

status-firefox83: --- → affected

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Status: UNCONFIRMED → NEW
Ever confirmed: true

The label is fixed by bug 1692667, now it's called "Open in New Container Tab"

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE

(In reply to Tooru Fujisawa [:arai] from comment #16)

The label is fixed by bug 1692667, now it's called "Open in New Container Tab"

*** This bug has been marked as a duplicate of bug 1692667 ***

The renaming of the label doesn't change the issue reported here. The problem is if a user click "Open in New Container Tab", the original tab isn't automatically closed and the user ends up with two similar tab (one in the current context and one in the newer selected context).

This is confusing at best and a privacy issue at worst since the user may have opened the original URL in the wrong container by accident and could potentially interact with it again by inadvertance. Closing the original tab after moving it to the selected container would avoid this issue.

Taking this into consideration, I think this issue should be reopened. Thanks.

Flags: needinfo?(arai.unmht)

to my understanding that's separate issue than the original one

(In reply to Danny Colin [:sdk] from comment #5)

Also, I've opened this issue because the word "reopen" imply that something
has been closed before it was reopened. If not, it should be named "open in
container".

Flags: needinfo?(arai.unmht)

Well, I'm the one who filed this bug report and the label was indeed incorrect for the current behavior that happens but my main concern in the top comment is that it doesn't automatically close the original tab and so creates a duplicate.

Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Severity: normal → S3

I got tired of this and made an extension that tries to mimic the native Firefox behaviour but closes the original tab. I don't know how to change the colour of SVG icons in context menu but other than that it seems to work fine. Originally I wanted to replace that context menu item to retain the following workflow:

  1. right click tab
  2. press "e" (for "Open in New Container Tab")
  3. press first letter of container name

However, I don't think it's possible from the extension so it creates a new menu item instead that can be opened by right click -> "q".

(In reply to cyprian.guerra from comment #20)

I got tired of this and made an extension that tries to mimic the native Firefox behaviour but closes the original tab.

Great initiative!

It's sad that this isn't the default behavior..

You need to log in before you can comment on or make changes to this bug.