Closed Bug 1511484 Opened 6 years ago Closed 5 years ago

[wpt-sync] Sync PR 14311 - Don't estimate the top of bottom-aligned OOFs as bottom.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 14311 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14311
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:
>  Don't estimate the top of bottom-aligned OOFs as bottom.
>  
>  We'll incorrectly think that we get fragmented in that case, which will
>  lead to incorrect height, which will lead to incorrect top offset,
>  which will lead to incorrect fragmentation.
>  
>  This has probably been the cause for a flaky web test, that behaved
>  even worse in LayoutNG, because in NG we force legacy layout as soon as
>  fragmentation is involved (so when entering printing, we typically need
>  to rebuild the entire layout object tree, with no former height to base
>  the bottom estimate on (which is what saved us when NG is disabled -
>  ehm, at least most of the time)).
>  
>  Bug: 910300
>  Change-Id: I8e152f77e9a94bb05e51f02a24be6ef5fe03c6f9
>  Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1355920
>  WPT-Export-Revision: e2e38838c32cc97786dcc9e5695874ab48ab25d8
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 2 tests and 3 subtests
OK     : 1
PASS   : 3
FAIL   : 1

New tests that have failures or other problems:
/css/css-break/block-end-aligned-abspos-with-overflow.html: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8062a5a3bd5
[wpt PR 14311] - Don't estimate the top of bottom-aligned OOFs as bottom., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d7bbdbb5355
[wpt PR 14311] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/d8062a5a3bd5
https://hg.mozilla.org/mozilla-central/rev/9d7bbdbb5355
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.