1511485 - WasmTextToBinary: does not accept all valid characters in identifiers (slash, backslash)

Status: VERIFIED DUPLICATE of bug 1612534

(Core :: JavaScript: WebAssembly, defect, P3)

Description

[Volker Berlin]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36

Steps to reproduce:

Call the the line:
wasmTextToBinary(read('test.wat'));

with the file content:
(module
  (import "global.Math" "max" (func $de/inetsoftware/jwebassembly/CallFunctions$TestClass.abc))
)


Actual results:

SyntaxError: wasm text error: parsing wasm text at 2:40

I test version JavaScript-C65.0a1 from https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/jsshell-win64.zip


Expected results:

Laut webassembly spec at https://webassembly.github.io/spec/core/text/values.html#text-id

are slashes and backslashes valid characters in identifiers and it should be parsed.

Comment 1

[Ryan Hunt [:rhunt] (on leave until early May)]

(In reply to Volker Berlin from comment #0)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36

Steps to reproduce:

Call the the line:
wasmTextToBinary(read('test.wat'));

with the file content:
(module
(import "global.Math" "max" (func
$de/inetsoftware/jwebassembly/CallFunctions$TestClass.abc))
)

Actual results:

SyntaxError: wasm text error: parsing wasm text at 2:40

I test version JavaScript-C65.0a1 from
https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
jsshell-win64.zip

Expected results:

Laut webassembly spec at
https://webassembly.github.io/spec/core/text/values.html#text-id

are slashes and backslashes valid characters in identifiers and it should be
parsed.

Just tested this again now that bug 1612534 has landed and this now passes.