1511571 - [autoconfig] Make domain bold

Status: RESOLVED FIXED

Description

[Ben Bucksch (:BenB)]

In the account creation dialog, when we found a config, we display the result config in a concise way.

To allow the user to more easily make secure decisions, we should make the second level domain of the hostname bold. E.g. for imap.mail.yahoo.com, we should make "yahoo.com" bold.

This is the trust anchor, and in fact more important than SSL: An attacker can easily set up SSL on his own domain, but he can't easily get the correct domain.

Comment 1

[Ben Bucksch (:BenB)]

Attachment: [autoconfig] Make domain bold

To allow the user to more easily make secure decisions, we should make the second level domain of the hostname bold. E.g. for imap.mail.yahoo.com, we should make "yahoo.com" bold.

Comment 2

[Ben Bucksch (:BenB)]

Comment on attachment 9029122 [details]
[autoconfig] Make domain bold

aceman r+ on Phab

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f6a51d60470f
[autoconfig] Make domain bold. r=aceman DONTBUILD

Comment 4

[Ben Bucksch (:BenB)]

Attachment: Trivial fix for typo in CSS

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9f896c82471d
[autoconfig] Make domain bold - Fix typo in CSS. r=jorgk

Comment 6

[:aceman]

I did point out the typo on Phabricator :)

Comment 7

[Jorg K (GMT+2)]

Well, that Phabricator is so totally well integrated (not!) that mistakes like this a bound to happen. The patch was first landed in the wrong bug since I had to copy together a HG header and I got the bug number wrong by mistake.

Curiously "hg phabread" usually produces a complete header, but not in for Ben & Co where the header is missing the author and the bug number. BTW, Lando refuses to land them with:
  Diff does not have proper author information in Phabricator. See the Lando FAQ for help with this error.

Fun fact: "hg phabread" produced a patch encoded in windows-1252/ISO-8859-1, so ellipses went up the creek, and had it not been for a merge/apply error, I wouldn't have noticed that either.

Quoting from the chat:
23:37:09 - BenB: mozilla braucht so ein riesen-geschrotter an tools, die mich alle haare verlieren lassen.
23:37:58 - BenB: ich sage nur: ich habe heute ein paar stunden verloren bei den versuch, das alles aufzusetzen.
confirms that the whole Phab stuff is a giant productivity destroyer, at least so far.

The positive side is that I can now land M-C patches without having to have an m-i repository locally.

Comment 8

[Jorg K (GMT+2)]

BTW, the Windows instructions are just a joke: https://moz-conduit.readthedocs.io/en/latest/arcanist-windows.html
"Only" 12 steps to set it up. Compare that to "hg qnew -m "Bug NNN - fixed yah di yah. r=aceman" NNN-fixed-yah-di-yah.patch" and upload; there was even a HG tool to upload patches automatically.

And "hg qimport" has never re-encoded patches in a different charset so far for me.

Comment 9

[Jorg K (GMT+2)]

Beta (TB 65):
https://hg.mozilla.org/releases/comm-beta/rev/dacb68554465e5daf329f5f9502932c0bd5f62af (merged patch incl. typo fix)

Comment 10

[Jorg K (GMT+2)]

Beta backout:
https://hg.mozilla.org/releases/comm-beta/rev/195a2aef72e1ab507c07ca93e703600b4b09c3b3

Comment 11

[Jorg K (GMT+2)]

TB 65 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/ccac3411796aaae4bb4bf6f76cd5d388c1a08cfc (merged patch incl. typo fix)

Comment 12

[Ben Bucksch (:BenB)]

Please do not put this in TB 60 in its current form. It uses new strings and makes everything fail. I might update it. But this fix is just optics and is not required for Exchange or Owl, so we could skip this for TB 60.

Comment 13

[Jorg K (GMT+2)]

Your call. BTW the patch does not have new strings, you only remove some.

Comment 14

[Ben Bucksch (:BenB)]

True. However, it uses a new string that bug 1500105 trunk patch added. The TB 60 patch for bug 1500105 doesn't have that new string and thus the patch here fails.
I could make a new, TB 60 specific patch. But given that this bug is only an optical improvement, and I'd rather push this out to TB 60.6 or skip it entirely.