Closed Bug 1511579 Opened 6 years ago Closed 5 years ago

[wpt-sync] Sync PR 14320 - Revert "[EventTiming] Always buffer firstInput"

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox66 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 14320 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14320
Details from upstream follow.

Sebastien Seguin-Gagnon <sebsg@chromium.org> wrote:
>  Revert "[EventTiming] Always buffer firstInput"
>  
>  This reverts commit b6e2cb9b364649724a1577b0c842074e12b82f27.
>  
>  Reason for revert: Causing WebKitLayout tests failure on linux:
>  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/76109
>  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/76108
>  
>  Original change's description:
>  > [EventTiming] Always buffer firstInput
>  > 
>  > Before, we'd buffer the firstInput entry only if it happened before
>  > onload. This CL forces firstInput to always be buffered. This means
>  > EventTiming code is called more in some tests, so the event hardware
>  > timestamp is no longer guaranteed to be nonzero, and a couple of xr
>  > tests require double RAF to avoid competing with the swap promises from
>  > Event Timing.
>  > 
>  > Bug: 841224, 843184
>  > 
>  > Change-Id: I942b934c387798c100da4ecfff52affb66ab94e8
>  > Reviewed-on: https://chromium-review.googlesource.com/c/1355880
>  > Reviewed-by: Timothy Dresser \<tdresser@chromium.org>
>  > Commit-Queue: Nicolás Peña Moreno \<npm@chromium.org>
>  > Cr-Commit-Position: refs/heads/master@{#612703}
>  
>  TBR=tdresser@chromium.org,npm@chromium.org
>  
>  Change-Id: I4b2456f4b9f44798b3157bea960d84f72a50a8bb
>  No-Presubmit: true
>  No-Tree-Checks: true
>  No-Try: true
>  Bug: 841224, 843184
>  Reviewed-on: https://chromium-review.googlesource.com/c/1357404
>  Reviewed-by: Sebastien Seguin-Gagnon \<sebsg@chromium.org>
>  Commit-Queue: Sebastien Seguin-Gagnon \<sebsg@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#612790}
>
PR 14320 applied with additional changes from upstream: b9b7d2fe5ff6c06279e321c1a3e70ff61ddafa96, 753a43be34a75556916f2225cbdf8254c9d85070, 42061028f3951380908b400fb1b23a2d6e16bb22, 97fdb80e9b3bf9bb1d84c6cf9d312b527d92879c, a2e7e014f92c8daf98fb5915b39b9c013c543904, 5db2938a512815aeeb80a2b0d1c07e36364e0a87
Ran 2 tests and 2 subtests
TIMEOUT: 4

New tests that have failures or other problems:
/event-timing/event-timing-onloadthenobserve-firstInput.html: TIMEOUT
    Event Timing: check firstInput after onload, observer, click, click.: TIMEOUT
/event-timing/event-timing-onloadthenobserve.html: TIMEOUT
    Event Timing: onload, click, observer, click.: TIMEOUT
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7656b12249ea
[wpt PR 14320] - Revert "[EventTiming] Always buffer firstInput", a=testonly
https://hg.mozilla.org/mozilla-central/rev/7656b12249ea
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.