151158 - renault-rent.com - DHTML menus don't work because they were written with prehistoric code

Status: RESOLVED WORKSFORME

(Tech Evangelism Graveyard :: French, defect)

Description

[Pascal Chevrel (relman team) -> :pascalc]

The brand new car renting Renault site has non standard DHTML menus : 

http://www.renault-rent.com/images/menudhtml-home.js

Their technical credits :

tequila rapido. : Web design, réalisation, et développement
2, place Garibaldi 06300 Nice - Tel : [phone], rue de la Paix 75002
Paris - Tel : [phone] [e-mail] - www.tequilarapido.com

One more Renault web site using bad coding pratices :

Bug 120601

Comment 1

[Tristan Nitot]

Confirming

Comment 2

[Gilles Durys]

*** Bug 151159 has been marked as a duplicate of this bug. ***

Comment 3

[Brant Gurganus]

Lots of document.all and document.layers.  Proprietary

Comment 4

[Mathieu Pillard [:mat]]

have a fix. they should replace
http://www.renault-rent.com/images/menudhtml-home.js with the version im attaching.

Comment 5

[Mathieu Pillard [:mat]]

Attachment: /menudhtml-home.js replacement.

this version should make the layers show/hide onmouseover/onmouseout like
expected.

Comment 6

[Mathieu Pillard [:mat]]

sent letter to [e-mail] (got the adress from
http://www.renault-rent.com/location_voiture/infos/contact.php?lg=1), attached fix.

Comment 7

[Pascal Chevrel (relman team) -> :pascalc]

New Component

Comment 8

[Mathieu Pillard [:mat]]

Site seems flash only now. Anyone seeing problems? I don't have flash on this box :)

Comment 9

[Jean-François Rameau]

Many problems again:

Error: syntax error
Source File: http://www.renault-rent.com/js/fonctions.js
Line: 232, Column: 3
Source Code:
else if (emplacement == "G") {nb_emp_g += 1};	

I think the semicolon is not at the right place. 

Other problem: tried an express reservation

Error: event is not defined
Source File: http://www.renault-rent.com/location_voiture/tarifs/default.php?lg=1
Line: 1031

and 

Error: caract_spe is not defined
Source File: http://www.renault-rent.com/location_voiture/tarifs/default.php?lg=1
Line: 180

Anyone to confirm ?

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040615 Firefox/0.9

Comment 10

[Pascal Chevrel (relman team) -> :pascalc]

They also send us 1996 document.layers code now...

Comment 11

[Mathieu Pillard [:mat]]

Seems like they FIXED it... Anyone can confirm?

Comment 12

[Pascal Chevrel (relman team) -> :pascalc]

still not fixed, in
http://www.renault-rent.com/location_voiture/tarifs/default.php?lg=1 the OK
buttons don't work, they seem to use a IE-only ways to capture events, lots or
errors thrown in the js console.

Comment 13

[nemo]

Entire site seems to have been redone as flash.
Nor does the link in comment #12 exist.

In many ways this is just as much of a failure, but at least the bug doesn't exist anymore.