1511615 - Intermittent Tier 2 Android tests/jit-test/jit-test/tests/ctypes/conversion-finalizer.js | Segmentation fault (code 139, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.3 s]

Status: NEW

(Core :: JavaScript Engine: JIT, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: btara [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=215084132&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/LFKUCM8ST_SaYdoYgfEn6A/runs/0/artifacts/public/logs/live_backing.log

15:34:42     INFO -  TEST-PASS | tests/jit-test/jit-test/tests/ctypes/conversion-finalizer.js | Success (code 0, args "--ion-eager --ion-offthread-compile=off") [0.3 s]
15:34:42     INFO -  {"action": "test_start", "jitflags": "--ion-eager --ion-offthread-compile=off", "pid": 475, "source": "jittests", "test": "ctypes/conversion-finalizer.js", "thread": "main", "time": 1543678482.457999}
15:34:42     INFO -  {"action": "test_end", "extra": {"jitflags": "--ion-eager --ion-offthread-compile=off"}, "jitflags": "--ion-eager --ion-offthread-compile=off", "message": "Success", "pid": 475, "source": "jittests", "status": "PASS", "test": "ctypes/conversion-finalizer.js", "thread": "main", "time": 1543678482.762991}
15:34:43     INFO -  exception output: Segmentation fault
15:34:43     INFO -  Segmentation faultSegmentation faultExit code: 139
15:34:43     INFO -  FAIL - ctypes/conversion-finalizer.js
15:34:43  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/ctypes/conversion-finalizer.js | Segmentation fault (code 139, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.3 s]
15:34:43     INFO -  {"action": "test_start", "jitflags": "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads", "pid": 475, "source": "jittests", "test": "ctypes/conversion-finalizer.js", "thread": "main", "time": 1543678482.7640018}
15:34:43     INFO -  {"action": "test_end", "extra": {"jitflags": "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads"}, "jitflags": "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads", "message": "Segmentation fault", "pid": 475, "source": "jittests", "status": "FAIL", "test": "ctypes/conversion-finalizer.js", "thread": "main", "time": 1543678483.068821}
15:34:43     INFO -  INFO exit-status     : 139
15:34:43     INFO -  INFO timed-out       : False
15:34:43     INFO -  INFO stdout          > Segmentation fault
15:34:43     INFO -  INFO stderr         2> Segmentation fault
15:34:43     INFO -  TEST-PASS | tests/jit-test/jit-test/tests/ctypes/conversion-finalizer.js | Success (code 0, args "--baseline-eager") [0.3 s]

Comment 1

[Intermittent Failures Robot]

8 failures in 2808 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 8

Platform breakdown:
* android-hw-p2-8-0-arm7-api-16: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1511615&startday=2018-11-26&endday=2018-12-02&tree=all

Comment 2

[Intermittent Failures Robot]

2 failures in 1862 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* try: 2

Platform breakdown:
* android-hw-p2-8-0-arm7-api-16: 1
* android-hw-p2-8-0-android-aarch64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1511615&startday=2018-12-03&endday=2018-12-09&tree=all

Comment 3

[Chris Peterson [:cpeterson]]

This test failure affects both ARMv7 and ARM64 and is blocking us from enabling ARM jit-tests in automation.

Comment 4

[Chris Peterson [:cpeterson]]

64=wontfix because this is a long-standing test failure so we don't need to uplift the fix to the GV 64 relbranch.

Comment 5

[Intermittent Failures Robot]

1 failures in 2648 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* try: 1

Platform breakdown:
* android-hw-p2-8-0-arm7-api-16: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1511615&startday=2018-12-17&endday=2018-12-23&tree=all

Comment 6

[Bob Clary [:bc] (inactive)]

Attachment: bug-1511615-disable-jittests-conversion-finalizer.patch

Once Bug 1516913 and Bug 1511618 are resolved we will need to disable this test until it is fixed in order to enable the jit tests in production.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 9033714 [details] [diff] [review]
bug-1511615-disable-jittests-conversion-finalizer.patch

Review of attachment 9033714 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with addressing my comment (at the very least explain why we are skipping)

::: js/src/jit-test/tests/ctypes/conversion-finalizer.js
@@ +1,1 @@
> +// |jit-test| skip-if: !getBuildConfiguration()['x86'] && !getBuildConfiguration()['x64']

can we just do getBuildConfiguration()['arm'] || getBuildConfiguration()['arm64']

I guess it is just as verbose, maybe a comment here indicating why we are skipping this (link to bug, simple scope of problem: crash on android, etc.)

Comment 8

[Bob Clary [:bc] (inactive)]

https://searchfox.org/mozilla-central/source/js/src/builtin/TestingFunctions.cpp#123 doesn't support 'arm' so the hack is to detect when it is not x86/x64. I'll put a comment pointing to this bug.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9af9e57b3a59
disable js/src/jit-test/tests/ctypes/conversion-finalizer.js for android-hw-p2, r=jmaher.

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/9af9e57b3a59

Comment 11

[Chris Peterson [:cpeterson]]

Unassigning Bob because he is not responsible for fixing the test failure. He just disabled the failing test.

Comment 12

[Chris Peterson [:cpeterson]]

Removing [arm64] whiteboard tag since this test failure appears to affect both ARMv7 and ARM64 (and hasn't stopped us from shipping ARMv7 Fennec).

Comment 13

[Nicolas B. Pierron [:nbp]]

As mentioned in comment 12, we shipped with it for ARMv7, so this is probably not a P1.

Comment 14

[Iain Ireland [:iain]]

I've been poking away at this on and off, trying to replicate the crash. I've run tens of thousands of iterations on Sean's ARM box, and I haven't seen a single segfault. It therefore seems pretty likely that this is android-specific.

It took me a while, but I eventually managed to turn up this log on treeherder. It gives a short backtrace and indicates that a tombstone was created, but the tombstone itself was not uploaded.

(Technically, there are five different copies of the backtrace, each with a different pid. This looks like five retries, but there's indication anywhere else that we re-ran the testcase.)

It looks like I'm going to have to figure out how to run the shell on a phone to make more progress here.