statusbarpanel custom elements not working in Search messages dialog

RESOLVED FIXED in Thunderbird 66.0

Status

defect
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: aceman, Assigned: arshad)

Tracking

({regression})

Thunderbird 66.0
x86_64
Linux
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird65 fixed, thunderbird66 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

7 months ago
I found out the statusbarpanel elements from bug 1491660 are not working in SearchDialog.xul and possibly FilterListDialog.xul.
The customElements.js is not loaded here, https://searchfox.org/comm-central/source/mail/components/mailGlue.js#142 never runs.

Thus, there are no status messages shown in the dialog (e.g. how many messages were found). Only the progressmeter flashes by when search is in progress.
Reporter

Updated

7 months ago
Component: General → XUL Replacements
Product: Thunderbird → MailNews Core
Version: Trunk → 65
Assignee

Comment 1

7 months ago
It looks like the windows created by Services.wm.getMostRecentWindow, are the cases for which custom elements are not loaded.
Assignee

Comment 2

7 months ago
Comment on attachment 9029939 [details] [diff] [review]
loadStatusbarpanel.patch

Review of attachment 9029939 [details] [diff] [review]:
-----------------------------------------------------------------

forgot to flag you for review..
Attachment #9029939 - Flags: review?(acelists)

Comment 3

7 months ago
Comment on attachment 9029939 [details] [diff] [review]
loadStatusbarpanel.patch

Works for the search, but I don't think it's necessary for the filters. Do they display a status? I don't think so, see follow-up.
Attachment #9029939 - Flags: review?(acelists) → review+

Comment 4

7 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/dfd8686bf342
Load statusbarpanel custom element in SearchDialog.xul. r=jorgk
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED

Updated

7 months ago
Target Milestone: --- → Thunderbird 66.0

Comment 5

7 months ago
Comment on attachment 9029939 [details] [diff] [review]
loadStatusbarpanel.patch

Needs backport.
Attachment #9029939 - Flags: approval-comm-beta+

Comment 6

7 months ago
Attachment #9031295 - Flags: review?(acelists)

Comment 8

6 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/832d6196becb
Load statusbarpanel custom element in FilterListDialog.xul. r=aceman DONTBUILD

Comment 9

6 months ago
I got into trouble with Aceman for only landing half of the patch :-(
Reporter

Comment 10

6 months ago
Comment on attachment 9031295 [details] [diff] [review]
1511644-remove-showStatusString.patch

Review of attachment 9031295 [details] [diff] [review]:
-----------------------------------------------------------------

I don't agree with removing this. It may be unused right now, but should get back to be used in bug 243241.
It is also buggy and the "value" should be "label".
Attachment #9031295 - Flags: review?(acelists) → review-

Comment 11

6 months ago
Comment on attachment 9031295 [details] [diff] [review]
1511644-remove-showStatusString.patch

(In reply to :aceman from comment #10)
> I don't agree with removing this. It may be unused right now, but should get
> back to be used in bug 243241.
You're involved in too many old bugs :-(

> It is also buggy and the "value" should be "label".
OK, let's keep the buggy stuff around :-(
Attachment #9031295 - Attachment is obsolete: true
(In reply to :aceman from comment #10)
> I don't agree with removing this. It may be unused right now, but should get
> back to be used in bug 243241.

Eh, that bug will have to add what's needed then. We can't wait wait around anticipating every scenario. If something is unused, it's out.
You need to log in before you can comment on or make changes to this bug.