1511672 - Warnings about dependant name lookup in AsyncInvoker.h

Status: RESOLVED FIXED

(Core :: IPC: MSCOM, defect)

Description

[Ted Campbell [:tcampbell]]

I get the following warnings in a local Win10 build (using the vendored clang binary).

> 114:25.05 warning: obj-x86_64-pc-mingw32/dist/include/mozilla/mscom/AsyncInvoker.h:266:5 [-Wmicrosoft-template] use of undeclared identifier 'mAsyncCall'; unqualified lookup into dependent bases of class template 'AsyncInvoker' is a Microsoft extension
> 114:25.05 warning: obj-x86_64-pc-mingw32/dist/include/mozilla/mscom/AsyncInvoker.h:266:22 [-Wmicrosoft-template] use of undeclared identifier 'AsyncCallType'; unqualified lookup into dependent bases of class template 'AsyncInvoker' is a Microsoft extension
> 114:25.05 warning: obj-x86_64-pc-mingw32/dist/include/mozilla/mscom/AsyncInvoker.h:289:10 [-Wmicrosoft-template] use of undeclared identifier 'mAsyncCall'; unqualified lookup into dependent bases of class template 'AsyncInvoker' is a Microsoft extension
> 114:25.05 warning: obj-x86_64-pc-mingw32/dist/include/mozilla/mscom/AsyncInvoker.h:293:38 [-Wmicrosoft-template] use of undeclared identifier 'mAsyncCall'; unqualified lookup into dependent bases of class template 'AsyncInvoker' is a Microsoft extension

The fix is a few uses of |this->| and |typename|.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1511672 - Fix dependent base lookups in AsyncInvoker.h r?froydnj

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/933fb2f29cff
Fix dependent base lookups in AsyncInvoker.h r=froydnj

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/933fb2f29cff

Comment 4

[Tom Ritter [:tjr]]

Attachment: Bug 1511672 - Fix dependent base lookups in AsyncInvoker.h r=froydnj (esr60)

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed for the mingwclang build to be able to --enable-accesibility

User impact if declined: Tor will have to carry an additional few patches; and we will have no mingwclang build on TC that compiled with --enable-accessibility (so if it broke we wouldn't notice until Tor did a release.)

Fix Landed on Version: 66.0a1 / 20181211093801

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): All it does is make the compiler happy.

String or UUID changes made by this patch:

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9036095 [details] [diff] [review]
Bug 1511672 - Fix dependent base lookups in AsyncInvoker.h r=froydnj (esr60)

build fix for mingwclang, approved for 60.5esr

Comment 6

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/a78d31ef649a