Closed Bug 1511714 Opened 6 years ago Closed 6 years ago

JavaScript error: resource:///modules/sessionstore/StartupPerformance.jsm, line 79: TypeError: Services.profiler is undefined; can't access its "AddMarker" property

Categories

(Firefox :: Session Restore, defect)

Unspecified
FreeBSD
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- unaffected
firefox64 --- unaffected
firefox65 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

(Keywords: regression)

Attachments

(1 file)

Services.profiler isn't available on Tier3 platforms without GeckoProfiler: Android x86_64, Linux powerpc/sparc/s390x, BSDs, Solaris.

https://searchfox.org/mozilla-central/rev/2edebf41a2b2e624859bf15ed5a98bdd002f73b4/tools/profiler/moz.build#11

$ c++ -v
FreeBSD clang version 7.0.1 (branches/release_70 346007) (based on LLVM 7.0.1)
Target: x86_64-unknown-freebsd13.0
Thread model: posix
InstalledDir: /usr/bin

$ ./mach bootstrap
$ ./mach build
$ ./mach run about:preferences
<Check "Restore previous session">
<Quit>
$ ./mach run
console.error: "StartupPerformance error" (new TypeError("Services.profiler is undefined; can't access its \"AddMarker\" property", "resource:///modules/sessionstore/StartupPerformance.jsm", 79)) "_onRestorationStarts@resource:///modules/sessionstore/StartupPerformance.jsm:79:5\nobserve@resource:///modules/sessionstore/StartupPerformance.jsm:153:11\nonBeforeBrowserWindowShown/<@resource:///modules/sessionstore/SessionStore.jsm:1326:11\npromise callback*onBeforeBrowserWindowShown@resource:///modules/sessionstore/SessionStore.jsm:1314:5\nssi_observe@resource:///modules/sessionstore/SessionStore.jsm:765:9\nonLoad@chrome://browser/content/browser.js:1393:5\nEventHandlerNonNull*@chrome://browser/content/browser.xul:106:19\n"
JavaScript error: resource:///modules/sessionstore/StartupPerformance.jsm, line 79: TypeError: Services.profiler is undefined; can't access its "AddMarker" property
Blocks: 1509571
Attached patch v1Splinter Review
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ecfa5c510e2ca77b7c29360dee05346f92bcc00
Assignee: nobody → jbeich
Attachment #9029223 - Flags: review?(mconley)
Comment on attachment 9029223 [details] [diff] [review]
v1

Review of attachment 9029223 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #9029223 - Flags: review?(mconley) → review+
Keywords: checkin-needed
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ff23eb2892a
Unbreak on platform without GeckoProfiler after bug 1509571. r=mconley
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6ff23eb2892a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: