1511730 - put nsBulletFrame-specific state bits in the correct group

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The nsBulletFrame-specific state bits are currently marked as "Block" rather than "Bullet"... even though there's a bullet group.  I *think* this looks like a mistake.

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=56f10b42f81fdc31877e74f72f9df7397ec46e38&group_state=expanded

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(The other question is why nothing was broken as a result of this!)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(I'm working on a patch to add some verification assertions, but I haven't yet thought of a decent way to do cross-group verification.)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Bug 1511730 patch 1 - But nsBulletFrame-specific state bits in the correct group. r=heycam

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Bug 1511730 patch 2 - Refactor the frame state group macros so that there's a unique header for every group. r=heycam

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Bug 1511730 patch 3 - Verify there are no frame state bit conflicts within groups. r=heycam

Without patch 1, this correctly triggers:
Assertion failure: !(bitsUsedPerGroup[group] & bit) (BULLET_FRAME_HAS_FONT_INFLATION must not use a bit already declared within its group), at /home/dbaron/builds/mozilla-central/mozilla/layout/generic/nsFrameStateBits.h:594

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce78f5cfca76dc7e13f30a48b834b73b77737ed5&group_state=expanded

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3984125e9c65
patch 1 - But nsBulletFrame-specific state bits in the correct group.  r=heycam
https://hg.mozilla.org/integration/autoland/rev/6faca87a7549
patch 2 - Refactor the frame state group macros so that there's a unique header for every group.  r=heycam
https://hg.mozilla.org/integration/autoland/rev/6fd0a7cc9a43
patch 3 - Verify there are no frame state bit conflicts within groups.  r=heycam

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3984125e9c65
https://hg.mozilla.org/mozilla-central/rev/6faca87a7549
https://hg.mozilla.org/mozilla-central/rev/6fd0a7cc9a43