1511777 - [wpt-sync] Sync PR 14334 - [css-text] Update 'line-break' tests

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 14334 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14334
Details from upstream follow.

MurakamiShinyu <[e-mail]> wrote:
>  [css-text] Update 'line-break' tests
>  
>  ### Fix test file name numbering
>  
>  The problem was that `line-break-normal-*` and `line-break-strict-*` had diffrent numbering for same ranges, e.g. `line-break-normal-021` and `line-break-strict-014` for same iteration marks. It was confusing, so I changed the numbering for 'normal' to be the same as for 'strict'.
>  
>  - line-break-normal-021  → line-break-normal-014
>  - line-break-normal-022  → line-break-normal-015
>  - line-break-normal-023a → line-break-normal-016a
>  - line-break-normal-023b → line-break-normal-016b
>  - line-break-normal-024a → line-break-normal-017a
>  - line-break-normal-024b → line-break-normal-017b
>  
>  ### Fix tests for Inseparatable characters
>  
>  The tests for Inseparatable characters `line-break-strict-015` and `line-break-normal-015` (was `line-break-normal-022`) had wrong assertion "does not allow line breaking **before** inseparable characters". This should be "does not allow line breaking **between** inseparable characters".
>  
>  I changed the tests to test line breaking **between** (not **before**) two inseparable characters.
>  
>  ### Fix tests for Centered punctuation marks
>  
>  The tests for Centered punctuation marks `line-break-strict-016a` and `line-break-normal-016a` (was `line-break-normal-023a`) contained tests for EAW=Narrow characters (U+003A, U+003B, U+0021, U+003F) that are excluded in the current 'line-break' spec.
>  
>  ### Fix tests for Postfixes
>  
>  The tests for Postfixes `line-break-strict-017a` and `line-break-normal-017a` (was `line-break-normal-024a`) contained tests for EAW=Narrow characters (U+0025 and U+00A2) that are excluded in the current 'line-break' spec.
>  
>  ### Add tests for Prefixes
>  
>  Added the tests for line breaking after Prefixes `line-break-*-018`.
>  
>  ### Add 'loose' and 'normal' values tests that were missing
>  
>  - line-break-loose-011 .. line-break-loose-017b
>  - line-break-normal-011 .. line-break-normal-013
>  
>  ### Adjust width of the test block
>  
>  I changed the width of the test block `p.test, p.control {...}` that was `width: 10em` to `width: 10.2em`. This extra (.2em) width is needed to prevent unexpected line breaking caused by some symbol characters wider than 1em.
>  
>  I found this problem with `line-break-loose-018`. The width of U+2116 "№" is slightly wider than 1em and if the block width is 10em the line breaking occurs before that character, and the test always fails.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=bde3293f91e6bac798d386aa4d3eb29f0ecd472c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e743e4010edcb114ead14233c4dc14829523eacd

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 30 tests
PASS   : 6
FAIL   : 24

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/css/css-text/line-break/line-break-strict-015.xht: FAIL

New tests that have failures or other problems:
/css/css-text/line-break/line-break-loose-011.xht: FAIL
/css/css-text/line-break/line-break-loose-012.xht: FAIL
/css/css-text/line-break/line-break-loose-013.xht: FAIL
/css/css-text/line-break/line-break-loose-014.xht: FAIL
/css/css-text/line-break/line-break-loose-015.xht: FAIL
/css/css-text/line-break/line-break-loose-016a.xht: FAIL
/css/css-text/line-break/line-break-loose-016b.xht: FAIL
/css/css-text/line-break/line-break-loose-017a.xht: FAIL
/css/css-text/line-break/line-break-loose-017b.xht: FAIL
/css/css-text/line-break/line-break-loose-018.xht: FAIL
/css/css-text/line-break/line-break-normal-011.xht: FAIL
/css/css-text/line-break/line-break-normal-012.xht: FAIL
/css/css-text/line-break/line-break-normal-013.xht: FAIL
/css/css-text/line-break/line-break-normal-014.xht: FAIL
/css/css-text/line-break/line-break-normal-015.xht: FAIL
/css/css-text/line-break/line-break-normal-017a.xht: FAIL
/css/css-text/line-break/line-break-normal-017b.xht: FAIL
/css/css-text/line-break/line-break-normal-018.xht: FAIL
/css/css-text/line-break/line-break-strict-018.xht: FAIL

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9035753ebcf
[wpt PR 14334] - [css-text] Update 'line-break' tests, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/237c20fa70ed
[wpt PR 14334] - Update wpt metadata, a=testonly

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f9035753ebcf
https://hg.mozilla.org/mozilla-central/rev/237c20fa70ed