1511794 - [wpt-sync] Sync PR 14335 - Revert "Enforce active lifetime of XRFrame objects"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 14335 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14335
Details from upstream follow.

Guido Urdaneta <[e-mail]> wrote:
>  Revert "Enforce active lifetime of XRFrame objects"
>  
>  This reverts commit ff451c7bfc7010d9bea16d7b7036be389afa1db5.
>  
>  Reason for revert: Suspect of causing consistent failure of xr_browser_tests on Win10 Debug (NVIDIA) bot.
>  
>  See 
>  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Debug%20%28NVIDIA%29
>  
>  First failure:
>  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Debug%20%28NVIDIA%29/10962
>  
>  
>  
>  Original change's description:
>  > Enforce active lifetime of XRFrame objects
>  > 
>  > Deactivates XRFrame objects once the relevant callback returns, which
>  > causes future calls to the object methods to throw an exception.
>  > 
>  > Bug: 906842
>  > Change-Id: I192453f9f23b1b4d9a404daca352ab80a5393753
>  > Reviewed-on: https://chromium-review.googlesource.com/c/1343065
>  > Commit-Queue: Brandon Jones \<[e-mail]>
>  > Reviewed-by: Klaus Weidner \<[e-mail]>
>  > Cr-Commit-Position: refs/heads/master@{#612887}
>  
>  TBR=[e-mail],[e-mail]
>  
>  # Not skipping CQ checks because original CL landed > 1 day ago.
>  
>  Bug: 906842
>  Change-Id: I26eb3477ea875362a5f1e6fd0b67bbe4a3c2c4a5
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1356945
>  WPT-Export-Revision: c65ace6ba785a97288a78f29b86e74c43fb38747

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 14335 applied with additional changes from upstream: 9d2147112a679205895db96ce8a580b2068d090c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9510aed1db28297555b25274b3b5c0f9d17c65f

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c71f4cef3a5a10b69099937ca241630c4ee85d6

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/88c0c92c8007
[wpt PR 14335] - Revert "Enforce active lifetime of XRFrame objects", a=testonly

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Result changes from PR not available.

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/88c0c92c8007