Closed Bug 1511878 Opened 3 years ago Closed 3 years ago
Text computes to black on mac OS 10 .14
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:63.0) Gecko/20100101 Firefox/63.0 Steps to reproduce: Open the attached file graytext_2cases.html. The expanded select list has the first item disabled, but it is still black, not gray. Actual results: The first option, which is disabled, is black, not gray in the expanded select list Expected results: The disabled item should have been gray in the expanded list. Chrome has the same problem, but Safari does not. It only appears to impact OS X, and maybe only 10.14. Windows browsers are not impacted.
Neil, do you know if this is working like that on OSX only by design?
Component: CSS Parsing and Computation → Layout: Form Controls
I don't see any issue in 10.13 -- the disabled option looks grey. Perhaps this is a native theme issue in 10.14 only?
This isn't restricted to text list. The following also reproduces the issue: data:text/html,<p style="color: GrayText;">This text should be grey</p> Curious that it works in the combobox. Maybe that's because the combobox dropdown renders in the parent process?
Status: UNCONFIRMED → NEW
Component: Layout: Form Controls → CSS Parsing and Computation
Ever confirmed: true
Priority: -- → P2
Summary: CSS graytext gets rendered as (0,0,0) in expanded select list → CSS GrayText computes to black on macOS 10.14
That color comes from: https://searchfox.org/mozilla-central/rev/fc229ed2c78648e402a9bbd50d99b69d0e227844/widget/cocoa/nsLookAndFeel.mm#783
Component: CSS Parsing and Computation → Widget: Cocoa
Assignee: nobody → spohl.mozilla.bugs
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 9036375 [details] [diff] [review] Patch Review of attachment 9036375 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! If we add more callers of this type, it might make sense to have two functions, GetRGBColorFromNSColor and GetRGBAColorFromNSColor, but for now it doesn't seem needed.
Attachment #9036375 - Flags: review?(mstange) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/62f90a1062e5d87c38c5431c17af6fbdd8c7b059 Bug 1511878: Start respecting the alpha channel for disabled control text color on macOS to accommodate the way this system color is declared by the OS on macOS 10.14+. r=mstange
Attachment #9036375 - Flags: approval-mozilla-beta?
You need to log in before you can comment on or make changes to this bug.