Closed
Bug 1511894
Opened 6 years ago
Closed 6 years ago
Remove wasm test from WPT exclusion list
Categories
(Testing :: web-platform-tests, enhancement)
Tracking
(firefox65 fixed)
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: bbouvier, Assigned: KWierso)
Details
Attachments
(1 file)
625 bytes,
patch
|
Details | Diff | Splinter Review |
(In reply to Benjamin Bouvier [:bbouvier] from bug 1499003 comment #7) > For what it's worth, the wasm abort test should have been fixed properly by > bug 1505632 which landed a few days ago. Can it be removed from the > exclusion list? Wes, are you interested in doing this? Or can you tell me how I can do it? Thanks!
Flags: needinfo?(wkocher)
Assignee | ||
Comment 1•6 years ago
|
||
You basically just undo this change https://hg.mozilla.org/mozilla-central/diff/cda49d66b3cc/testing/web-platform/meta/wasm/webapi/abort.any.js.ini So just `hg rm testing/web-platform/meta/wasm/webapi/abort.any.js.ini`. Alternatively, just removing these two lines should do the same thing (leave the two lines that start with '['): disabled: if os == "android": https://bugzilla.mozilla.org/show_bug.cgi?id=1499003 I can take this one, though. :) I did some try pushes to make sure this doing this doesn't break anything. First, a clean pull from mozilla-central: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=8899651d98697192cd396e2f7a74d71ceae66aad Second, that clean pull, plus removing the test-skipping for this test: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=9894422febb4d5bbe6e1b45802413a91113c2a78 Once those finish up, I can reenable the test.
Assignee: nobody → wkocher
Flags: needinfo?(wkocher)
Pushed by wkocher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/23f6608c96b8 Re-enable wasm abort.any.js on fennec wpt r=me a=testonly
Assignee | ||
Comment 3•6 years ago
|
||
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/23f6608c96b8
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•