Enable MEMORY_TOTAL telemetry in release

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P1
normal
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: erahm, Assigned: erahm)

Tracking

unspecified
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(2 attachments, 3 obsolete attachments)

Gather telemetry on the memory usage of our release cohort will be particularly useful for fission memshrink efforts.
Blocks: 1511183
Attachment #9029369 - Flags: review?(chutten)
Posted file MEMORY_TOTAL_data_review.txt (obsolete) —
Attachment #9029372 - Flags: feedback?(chutten)
Attachment #9029369 - Flags: review?(chutten) → review+
Comment on attachment 9029369 [details] [diff] [review]
Enable MEMORY_TOTAL telemetry in release

Review of attachment 9029369 [details] [diff] [review]:
-----------------------------------------------------------------

Oh wait, this is a permanent measure? It needs an individual in the alert_emails list (same individual as in the Data Collection Review). Also, now I notice that this bug should be included in the bug_numbers list as well.
Attachment #9029369 - Flags: review+ → review-
Comment on attachment 9029372 [details]
MEMORY_TOTAL_data_review.txt

Since MEMORY_TOTAL hasn't undergone the latest version of Data Collection Review in the past we should fill out the review form as though this were a new collection. This collection isn't currently at the standard needed for permanent, all-channel collection (needs an individual who volunteered to monitor it over time, needs full documentation about why it is collected and needed, and would probably benefit from an automated test to ensure it doesn't break)
Attachment #9029372 - Flags: feedback?(chutten) → feedback-
Attachment #9029702 - Flags: review?(chutten)
Attachment #9029369 - Attachment is obsolete: true
Posted file MEMORY_TOTAL_data_review.txt (obsolete) —
More clearly filled out.
Attachment #9029372 - Attachment is obsolete: true
Attachment #9029709 - Flags: review?(chutten)
(In reply to Chris H-C :chutten from comment #4)
> Comment on attachment 9029372 [details]
> MEMORY_TOTAL_data_review.txt
> 
> Since MEMORY_TOTAL hasn't undergone the latest version of Data Collection
> Review in the past we should fill out the review form as though this were a
> new collection. This collection isn't currently at the standard needed for
> permanent, all-channel collection (needs an individual who volunteered to
> monitor it over time, needs full documentation about why it is collected and
> needed, and would probably benefit from an automated test to ensure it
> doesn't break)

re: automated test, kmag is actively rewriting this code in bug 1505522, I'll ask him to add tests there (it looks like we having testing for a few values, but not MEMORY_TOTAL, elsewhere [1]).

[1] https://searchfox.org/mozilla-central/rev/3fdc51e66c9487b39220ad58dcee275fca070ccd/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js#369
Attachment #9029702 - Flags: review?(chutten) → review+
Attachment #9029709 - Attachment is obsolete: true
Attachment #9029750 - Flags: review?(chutten)
Priority: -- → P1
Comment on attachment 9029750 [details]
MEMORY_TOTAL_data_review.txt

Apologies for the delayed response here, also.

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? 

Yes. This collection is Telemetry so is documented in its definitions file (Histograms.json), the Probe Dictionary, and on telemetry.mozilla.org's Measurement Dashboards.

    Is there a control mechanism that allows the user to turn the data collection on and off? 

Yes. This collection is Telemetry so can be controlled in Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :erahm will.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

    Is the data collection covered by the existing Firefox privacy notice? 

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data? 

No. The collection is permanent.

---
Result: datareview+
Attachment #9029750 - Flags: review?(chutten) → review+
Oh, right, nearly forgot. Memory collections done in `gatherMemory` are pre-release only in code as well as by Histograms.json definition. You'll need to do something similar to GHOST_WINDOWS to get this collecting in the release channel: https://searchfox.org/mozilla-central/rev/fd62b95c187a40b328d9e7fd9d848833a6942b57/toolkit/components/telemetry/other/MemoryTelemetry.jsm#175
(In reply to Chris H-C :chutten from comment #10)
> Oh, right, nearly forgot. Memory collections done in `gatherMemory` are
> pre-release only in code as well as by Histograms.json definition. You'll
> need to do something similar to GHOST_WINDOWS to get this collecting in the
> release channel:
> https://searchfox.org/mozilla-central/rev/
> fd62b95c187a40b328d9e7fd9d848833a6942b57/toolkit/components/telemetry/other/
> MemoryTelemetry.jsm#175

Ack, good catch! I'll file a follow up for that.
Blocks: 1513392
Pushed by erahm@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e10798248f4
Enable MEMORY_TOTAL telemetry in release. r=chutten
https://hg.mozilla.org/mozilla-central/rev/3e10798248f4
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.