1511963 - contain-layout-suppress-baseline-002.html points to the wrong reference

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Manuel Rego Casasnovas]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36

Steps to reproduce:


The test is linking to contain-layout-suppress-baseline-001-ref.html while it should link to contain-layout-suppress-baseline-002-ref.html.

Comment 1

[Manuel Rego Casasnovas]

Attachment: 0001-Bug-1511963-Fix-reference-in-contain-layout-suppress.patch

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9029408 [details] [diff] [review]
0001-Bug-1511963-Fix-reference-in-contain-layout-suppress.patch

Review of attachment 9029408 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 3

[Daniel Holbert [:dholbert]]

Thanks for fixing this!

Though: technically we should be fixing this in the layout/reftests/w3c-submitted version (that's the "master copy" in our source tree, and then we do single-directional sync from there to upstream and then bidirectional sync between upstream wpt and our wpt import).

Right now, I suspect this patch's changes will just get overwritten unless you include the layout/reftests copy as well.

Comment 4

[Daniel Holbert [:dholbert]]

So specifically, the file that needs fixing here is:

https://searchfox.org/mozilla-central/source/layout/reftests/w3c-css/submitted/contain/contain-layout-suppress-baseline-002.html#9

Ideally we should make this fix in *only* that version of the test, and allow the normal sync pipeline to play itself out (and I think dbaron syncs that to upstream wpt ~weekly).

If you want to fix both in-tree copies (as you did in bug 1491235), that's OK too, but slightly less preferred - it just adds a small bit of overhead when dbaron does the sync, I think.

Comment 5

[Daniel Holbert [:dholbert]]

oops, disregard comment 3 and 4; I could've sworn that this was in our wpt import when I glanced at the test, but I just rechecked and it's doing exactly what it should be doing. :D

Clearly I need to finish my cup of coffee.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/84c1e131a7fa
Fix reference in contain-layout-suppress-baseline-002.html r=emilio

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/84c1e131a7fa

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

wpt merge in https://github.com/web-platform-tests/wpt/pull/14375