1511988 - aboutNetworking.ftl is using windows line endings

Status: VERIFIED FIXED

(Core :: Networking, defect, P1)

Description

[Axel Hecht [:Pike]]

aboutNetworking.ftl is using windows line endings, which are not valid newlines in fluent anymore. We'll need to convert that.

This seems to be the only file on that:

Fuchsia:mozilla-central axelhecht$ file `find */locales/en-US -name \*.ftl`
browser/locales/en-US/browser/preferences/selectBookmark.ftl:     ASCII text
browser/locales/en-US/browser/preferences/syncDisconnect.ftl:     UTF-8 Unicode text
browser/locales/en-US/browser/preferences/permissions.ftl:        ASCII text
browser/locales/en-US/browser/preferences/languages.ftl:          UTF-8 Unicode text
browser/locales/en-US/browser/preferences/blocklists.ftl:         ASCII text
browser/locales/en-US/browser/preferences/colors.ftl:             ASCII text
browser/locales/en-US/browser/preferences/applicationManager.ftl: ASCII text
browser/locales/en-US/browser/preferences/connection.ftl:         ASCII text
browser/locales/en-US/browser/preferences/translation.ftl:        ASCII text
browser/locales/en-US/browser/preferences/siteDataSettings.ftl:   ASCII text
browser/locales/en-US/browser/preferences/preferences.ftl:        UTF-8 Unicode text
browser/locales/en-US/browser/preferences/clearSiteData.ftl:      ASCII text
browser/locales/en-US/browser/preferences/fonts.ftl:              ASCII text
browser/locales/en-US/browser/preferences/containers.ftl:         ASCII text
browser/locales/en-US/browser/branding/sync-brand.ftl:            UTF-8 Unicode text
browser/locales/en-US/browser/sanitize.ftl:                       ASCII text
browser/locales/en-US/browser/policies/policies-descriptions.ftl: UTF-8 Unicode text
browser/locales/en-US/browser/newtab/asrouter.ftl:                UTF-8 Unicode text
browser/locales/en-US/browser/newtab/onboarding.ftl:              UTF-8 Unicode text
browser/locales/en-US/browser/aboutSessionRestore.ftl:            UTF-8 Unicode text
browser/locales/en-US/browser/aboutDialog.ftl:                    UTF-8 Unicode text
browser/locales/en-US/browser/aboutSearchReset.ftl:               UTF-8 Unicode text
browser/locales/en-US/browser/aboutRestartRequired.ftl:           ASCII text
browser/locales/en-US/browser/aboutPolicies.ftl:                  ASCII text
toolkit/locales/en-US/crashreporter/aboutcrashes.ftl:             ASCII text
toolkit/locales/en-US/toolkit/preferences/preferences.ftl:        ASCII text
toolkit/locales/en-US/toolkit/main-window/findbar.ftl:            ASCII text
toolkit/locales/en-US/toolkit/main-window/editmenu.ftl:           ASCII text
toolkit/locales/en-US/toolkit/about/aboutConfig.ftl:              ASCII text
toolkit/locales/en-US/toolkit/about/aboutProfiles.ftl:            UTF-8 Unicode text
toolkit/locales/en-US/toolkit/about/aboutNetworking.ftl:          ASCII text, with CRLF line terminators
toolkit/locales/en-US/toolkit/about/aboutPerformance.ftl:         ASCII text
toolkit/locales/en-US/toolkit/about/aboutAddons.ftl:              UTF-8 Unicode text
toolkit/locales/en-US/toolkit/about/url-classifier.ftl:           ASCII text
toolkit/locales/en-US/toolkit/about/aboutAbout.ftl:               UTF-8 Unicode text
toolkit/locales/en-US/toolkit/updates/history.ftl:                ASCII text
Fuchsia:mozilla-central axelhecht$ file `find */locales/en-US -name \*.ftl`|grep CR
toolkit/locales/en-US/toolkit/about/aboutNetworking.ftl:          ASCII text, with CRLF line terminators

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Collin - can you please fix that and ensure your editor uses NL line endings?

Comment 2

[Francesco Lodolo [:flod]]

Leaving the NI open to fix the edition, but we're holding up DevEdition builds, and can't wait for a contributor to fix this.

Comment 3

[Francesco Lodolo [:flod]]

Attachment: Bug 1511988 - Convert aboutNetworking.ftl to LF line ending

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/47077594d943
Convert aboutNetworking.ftl to LF line ending r=Pike a=release-bustage

Comment 5

[Francesco Lodolo [:flod]]

Also landed in Beta
https://hg.mozilla.org/releases/mozilla-beta/rev/34fd146e3a2c

Comment 6

[Staś Małolepszy :stas]

CRLF is still a valid line ending in Fluent and there is no near future intention to change that. In Fluent Syntax 0.7 we only removed the support for using lone CRs as EOLs, see https://github.com/projectfluent/fluent/releases/tag/v0.7.0

Comment 7

[Axel Hecht [:Pike]]

AMO is using fluent-syntax 0.7, which has bugs in parsing comments with windows line endings.

fluent-syntax 0.8 has a different bug.

fluent-syntax 0.9 works.

I misreported that windows line endings are not supported in Fluent anymore, my brain failed me while watching keynotes. We unsupported os/9 pure \r, but \r\n is supported.

Filed https://github.com/mozilla/addons-linter/issues/2305 to get amo updated.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Respins have successfully completed. Thanks for the fast patching!