1512036 - Turn off clang formatting when defining JIT_COMPILER_OPTIONS, because the Google-approved autoformatting is outright barbarous

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 9029465 [details] [diff] [review]
Patch

Review of attachment 9029465 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi.h
@@ +4512,5 @@
>                                                                 bool enabled);
>  
> +// clang-format off
> +#define JIT_COMPILER_OPTIONS(Register) \
> +  Register(BASELINE_WARMUP_TRIGGER, "baseline.warmup.trigger") \

Another way to fix this is by s/Register/REGISTER/ I think, see https://bugzilla.mozilla.org/show_bug.cgi?id=1508064#c2 This works too though :)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3e95cb56799
Turn off clang formatting when defining JIT_COMPILER_OPTIONS, because the Google-approved autoformatting is outright barbarous.  r=jandem

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a3e95cb56799

Comment 6

[Ted Campbell [:tcampbell]]

In general, we should prefer |REGISTER| as a solution, but we can a scrub in a few months to reduce uses of |clang-format off|

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Another solution would have been to just add ";" at the end of the lines (I guess)