1512046 - Click on callstack grouped frames shouldn't propagate

Status: VERIFIED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

**Steps to reproduce**
1. Open the console
2. Evaluate the following: 

```
x = new Error("ooops")
x.stack = "a@http://exampl.com:1:1\n" +
    "grouped@http://react.js:1:1\n" +
    "grouped2@http://react.js:1:1";
console.error(x)
```
3. You should see a callstack with a React group, click on it


**Expected results**

The group is expanded

**Actual results**

The group is expanded, but so is the message (the arrow icon on the left is rotated, and the console.error callstack is displayed under the react callstack)

---

This is because the group click propagates, which shouldn't.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1512046 - Stop propagation of callstack group click; r=Honza.

This also adds a console test to make sure we don't regress
this in the future.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9c528fe96d5
Stop propagation of callstack group click; r=Honza.

Comment 3

[Andreea Pavel [:apavel]]

Backed out for failing devtools/client/webconsole/test/mochitest/browser_webconsole_error_with_grouped_stack.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=215835772&revision=a9c528fe96d5df7ee16d1c9d8f84c03b04ef850b

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=215835772&repo=autoland&lineNumber=4154

Backout: https://hg.mozilla.org/integration/autoland/rev/c9ff07bf8ef3e76000e14e51ffbcd65dbafcd441

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Erf, probably Bug 1508549 caused that.
I fixed the test and pushed to TRY again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e36591434de912c09c10e7d0d0c97c79dbcbfdd

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

latest try push https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5e4c2802d9f76fb810d51f38c82b8bc7253309b

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d93612673dc
Stop propagation of callstack group click; r=Honza.

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1d93612673dc

Comment 8

[Daniel Cicas [:dcicas], Release QA]

I reproduced this issue using Fx 65.0a1, build ID: 20181204215402, on Windows 10 x64 and Ubuntu 18.04.1 LTS.

I can confirm this issue is fixed, I verified using Fx 65.0b12, build ID: 20190117232427, on Windows 10 x64, macOS X 10.13 and Ubuntu 18.04.1 LTS.