Closed
Bug 1512054
Opened 6 years ago
Closed 6 years ago
Add missing #includes for "***Inlines.h" headers, in several layout subdirectories
Categories
(Core :: Layout, enhancement, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(2 files)
(this is similar to previous bug 1438020) Filing this for some needed "inlines" includes in layout (which are only revealed via build warnings when you turn off unified builds).
Assignee | ||
Comment 1•6 years ago
|
||
I'm also adding the non-"inlines" version of the added "inlines" includes, too, since it's nice to have them included as a pair. (It's not strictly necessary, since in these cases we were already indirectly including the non-"inlines" header, but it seems like a good practice.) This patch fixes build warnings in non-unified builds for the following calls: - The call to IsColumnSpan() in layout/generic/ColumnSetWrapperFrame.cpp - The call to Type() in layout/style/MappedDeclarations.cpp - The call to IsInAnonymousSubtree() in layout/svg/SVGObserverUtils.cpp
Updated•6 years ago
|
Attachment #9029477 -
Attachment description: Bug 1512054: Add some needed "Inlines" includes to .cpp files in layout, to address some -Wundefined-inline build warnings in non-unified builds. r?TYLin → Bug 1512054 part 1: Add some needed "Inlines" includes to .cpp files in layout, to address some -Wundefined-inline build warnings in non-unified builds. r?TYLin
Assignee | ||
Comment 2•6 years ago
|
||
(Also, include the full export path when including 'ImageLoader.h', for consistency with how we include it everywhere else outside of its own directory.) Depends on D13743
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0648f6fb0eef part 1: Add some needed "Inlines" includes to .cpp files in layout, to address some -Wundefined-inline build warnings in non-unified builds. r=TYLin https://hg.mozilla.org/integration/autoland/rev/d186ca68a92d part 2: Fix alphabetical sorting of SVGObserverUtils.cpp's includes. r=TYLin
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0648f6fb0eef https://hg.mozilla.org/mozilla-central/rev/d186ca68a92d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•