Closed Bug 1512082 Opened 6 years ago Closed 6 years ago

Perma-failing [try] 0:44.89 tools/tryselect/test/test_again.py::test_try_again TEST-UNEXPECTED-FAIL

Categories

(Testing :: Code Coverage, defect, P5)

Product:
Testing
Component:
Code Coverage
Version:
Version 3
Type:
defect

Tracking

(firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: marco)

References

Details

Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=215471875&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/XdoUaLueS3S57pNC9jyVwQ/runs/0/artifacts/public/logs/live_backing.log

[task 2018-12-04T21:59:47.223Z] Virtualenv location: /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/gecko-QUm8IANb-2
[task 2018-12-04T21:59:47.246Z] Creating a Pipfile for this project…
[task 2018-12-04T21:59:48.185Z] running build_ext
[task 2018-12-04T21:59:48.185Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2018-12-04T21:59:48.185Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2018-12-04T21:59:48.185Z] 
[task 2018-12-04T21:59:48.185Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2018-12-04T21:59:48.202Z] cat: backend.TestManifestBackend.in: No such file or directory
[task 2018-12-04T21:59:48.204Z] Build configuration changed. Regenerating backend.
[task 2018-12-04T21:59:48.695Z] No handlers could be found for logger "mozbuild.frontend.reader"
[task 2018-12-04T21:59:52.775Z] No build detected, test metadata may be incomplete.
[task 2018-12-04T22:00:15.938Z]  0:44.89 /builds/worker/checkouts/gecko/tools/tryselect/test/test_again.py
[task 2018-12-04T22:00:15.938Z]  0:44.89 ============================= test session starts ==============================
[task 2018-12-04T22:00:15.938Z]  0:44.89 platform linux2 -- Python 2.7.12, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/gecko-QUm8IANb-2/bin/python
[task 2018-12-04T22:00:15.938Z]  0:44.89 rootdir: /builds/worker/checkouts/gecko, inifile: /builds/worker/checkouts/gecko/config/mozunit/mozunit/pytest.ini
[task 2018-12-04T22:00:15.938Z]  0:44.89 collecting ... collected 2 items
[task 2018-12-04T22:00:15.940Z]  0:44.89 
[task 2018-12-04T22:00:15.940Z]  0:44.89 tools/tryselect/test/test_again.py::test_try_again TEST-UNEXPECTED-FAIL
[task 2018-12-04T22:00:15.940Z]  0:44.89 tools/tryselect/test/test_again.py::test_no_push_does_not_generate_history PASSED
[task 2018-12-04T22:00:15.940Z]  0:44.89 
[task 2018-12-04T22:00:15.940Z]  0:44.89 =================================== FAILURES ===================================
[task 2018-12-04T22:00:15.941Z]  0:44.89 ________________________________ test_try_again ________________________________
[task 2018-12-04T22:00:15.941Z]  0:44.89 
[task 2018-12-04T22:00:15.941Z]  0:44.89 monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f92ed18b890>
[task 2018-12-04T22:00:15.941Z]  0:44.89 
[task 2018-12-04T22:00:15.942Z]  0:44.89     def test_try_again(monkeypatch):
[task 2018-12-04T22:00:15.942Z]  0:44.89         push.push_to_try('fuzzy', 'Fuzzy message', ['foo', 'bar'], {'artifact': True})
[task 2018-12-04T22:00:15.943Z]  0:44.90 
[task 2018-12-04T22:00:15.944Z]  0:44.90         assert os.path.isfile(push.history_path)
[task 2018-12-04T22:00:15.944Z]  0:44.90         with open(push.history_path, 'r') as fh:
[task 2018-12-04T22:00:15.945Z]  0:44.90             assert len(fh.readlines()) == 1
[task 2018-12-04T22:00:15.945Z]  0:44.90 
[task 2018-12-04T22:00:15.945Z]  0:44.90         def fake_push_to_try(*args, **kwargs):
[task 2018-12-04T22:00:15.945Z]  0:44.90             return args, kwargs
[task 2018-12-04T22:00:15.945Z]  0:44.90 
[task 2018-12-04T22:00:15.945Z]  0:44.90         monkeypatch.setattr(push, 'push_to_try', fake_push_to_try)
[task 2018-12-04T22:00:15.945Z]  0:44.90         reload(again)
[task 2018-12-04T22:00:15.945Z]  0:44.90 
[task 2018-12-04T22:00:15.945Z]  0:44.90         args, kwargs = again.run_try_again()
[task 2018-12-04T22:00:15.946Z]  0:44.90 
[task 2018-12-04T22:00:15.946Z]  0:44.90         assert args[0] == 'again'
[task 2018-12-04T22:00:15.947Z]  0:44.90         assert args[1] == 'Fuzzy message'
[task 2018-12-04T22:00:15.948Z]  0:44.90 
[task 2018-12-04T22:00:15.949Z]  0:44.90         try_task_config = kwargs.pop('try_task_config')
[task 2018-12-04T22:00:15.950Z]  0:44.90         assert sorted(try_task_config.get('tasks')) == sorted(['foo', 'bar'])
[task 2018-12-04T22:00:15.951Z]  0:44.90 >       assert try_task_config.get('templates') == {'artifact': True}
[task 2018-12-04T22:00:15.952Z]  0:44.90 E       AssertionError: assert {'artifact': ...OR': 'fuzzy'}} == {'artifact': True}
[task 2018-12-04T22:00:15.953Z]  0:44.91 E         Common items:
[task 2018-12-04T22:00:15.954Z]  0:44.91 E         {u'artifact': True}
[task 2018-12-04T22:00:15.955Z]  0:44.91 E         Left contains more items:
[task 2018-12-04T22:00:15.956Z]  0:44.91 E         {u'env': {u'TRY_SELECTOR': u'fuzzy'}}
[task 2018-12-04T22:00:15.956Z]  0:44.91 E         Full diff:
[task 2018-12-04T22:00:15.958Z]  0:44.91 E         - {u'artifact': True, u'env': {u'TRY_SELECTOR': u'fuzzy'}}
[task 2018-12-04T22:00:15.959Z]  0:44.91 E         + {u'artifact': True}
[task 2018-12-04T22:00:15.960Z]  0:44.91 
[task 2018-12-04T22:00:15.961Z]  0:44.91 tools/tryselect/test/test_again.py:42: AssertionError
[task 2018-12-04T22:00:15.961Z]  0:44.91 ====================== 1 failed, 1 passed in 1.10 seconds ======================
[task 2018-12-04T22:00:15.963Z]  0:44.91 Setting retcode to 1 from /builds/worker/checkouts/gecko/tools/tryselect/test/test_again.py
[task 2018-12-04T22:00:20.184Z]  0:49.14 /builds/worker/checkouts/gecko/tools/tryselect/test/test_templates.py


This appeared when Bug 1488849 landed. Marco please take a look.
Flags: needinfo?(mcastelluccio)
I'll push a fix.
Assignee: nobody → mcastelluccio
Blocks: 1488849
Status: NEW → ASSIGNED
Flags: needinfo?(mcastelluccio)
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/84a17995db6f
Add TRY_SELECTOR env to templates expected value. r=me
Keywords: intermittent-failure
Flags: needinfo?(mcastelluccio)
https://hg.mozilla.org/mozilla-central/rev/84a17995db6f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Filed Bug 1512146 to better track the issue.
Fixed in bug 1512146.
Flags: needinfo?(mcastelluccio)
You need to log in before you can comment on or make changes to this bug.